Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datetime selection excludes edges #212

Closed
timwis opened this issue Dec 6, 2017 · 1 comment
Closed

Datetime selection excludes edges #212

timwis opened this issue Dec 6, 2017 · 1 comment
Labels
v2-old A previous attempt at v2 using chart.js and plottable

Comments

@timwis
Copy link
Owner

timwis commented Dec 6, 2017 •
edited
Loading

Seems like you have to start and end past the border for it to be included in the selection, and that's counter-intuitive. See palantir/plottable#3428.
@timwis timwis added the v2-old A previous attempt at v2 using chart.js and plottable label Dec 6, 2017
@timwis
Copy link
Owner Author

timwis commented Dec 8, 2017 •
edited
Loading

Maybe we can peg the dragbox bounds against the scale instead of the plot?

@timwis timwis closed this as completed Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v2-old A previous attempt at v2 using chart.js and plottable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@timwis