Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@storybook/storybook-deployer leaked into dependencies #479

Closed
Senderek opened this issue Nov 16, 2023 · 3 comments
Closed

@storybook/storybook-deployer leaked into dependencies #479

Senderek opened this issue Nov 16, 2023 · 3 comments
Labels
GitHub Issues that have been added to our internal issue tracker.

Comments

@Senderek
Copy link

What is the current behavior?
@tinymce/tinymce-react contains @storybook/storybook-deployer in the dependencies in package.json, which cascades to all configurations consuming @tinymce/[email protected]

Steps to reproduce

npm install @tinymce/[email protected]

What is the expected behavior?
Package forces the consuming application to only download the packages that are used during runtime when using npm i

Which versions of TinyMCE, and which browser / OS are affected by this issue? Did this work in previous versions of TinyMCE or tinymce-react?
Version: 4.3.1
PR: #478
In previous versions the dependency array only contained prop-types and tinymce

@exalate-issue-sync exalate-issue-sync bot added the GitHub Issues that have been added to our internal issue tracker. label Nov 16, 2023
Copy link

Internal Ref: INT-3252

@zavan
Copy link

zavan commented Nov 16, 2023

This causes a NPM security warning:

npm audit
# npm audit report

parse-url  <=8.0.0
Severity: critical
parse-url parses http URLs incorrectly, making it vulnerable to host name spoofing - https://github.com/advisories/GHSA-pqw5-jmp5-px4v
Server-Side Request Forgery (SSRF) in GitHub repository ionicabizau/parse-url - https://github.com/advisories/GHSA-j9fq-vwqv-2fm2
fix available via `npm audit fix --force`
Will install @tinymce/[email protected], which is a breaking change
node_modules/parse-url
  git-up  <=6.0.0
  Depends on vulnerable versions of parse-url
  node_modules/git-up
    git-url-parse  4.0.0 - 12.0.0
    Depends on vulnerable versions of git-up
    node_modules/git-url-parse
      @storybook/storybook-deployer  *
      Depends on vulnerable versions of git-url-parse
      node_modules/@storybook/storybook-deployer
        @tinymce/tinymce-react  >=4.3.1-feature.20230124174746421.sha998862c
        Depends on vulnerable versions of @storybook/storybook-deployer
        node_modules/@tinymce/tinymce-react

5 vulnerabilities (4 moderate, 1 critical)

To address all issues (including breaking changes), run:
  npm audit fix --force

@shanmen-tiny
Copy link
Collaborator

Hi @Senderek and @zavan ,

Thank you for reporting, and the issue has been addressed in #483, and we have removed the storybook-deployer dependency. A new version tinymce-react version (4.3.2) has been released and is now available for download from npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GitHub Issues that have been added to our internal issue tracker.
Projects
None yet
Development

No branches or pull requests

3 participants