Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github information to the footer #567

Open
jonespm opened this issue Oct 28, 2024 · 3 comments
Open

Add Github information to the footer #567

jonespm opened this issue Oct 28, 2024 · 3 comments
Labels
Effort: 4 Effort estimated at half-day good first issue Good for newcomers

Comments

@jonespm
Copy link
Member

jonespm commented Oct 28, 2024

It would be useful for admins to be able to see some information about when this instance was updated. In MyLA this was added to the footer only for admins. https://github.com/tl-its-umich-edu/my-learning-analytics/pull/284/files

I think this is probably fine to leave this restriction. We could probably also put it somewhere else like in Django Admin? Not sure we have to spend a lot of time on it.

This was using git to pull the version, maybe there's an easier way to get that information into the build, like through the Github Action?

@jonespm jonespm added Effort: 4 Effort estimated at half-day good first issue Good for newcomers labels Nov 11, 2024
@jadfalaoui
Copy link
Contributor

Hello, I would love to work on this issue in the context of my final assignment for EECS 481: Software Engineering. Please let me know if this is still a feature you would like to see implemented!

@jonespm
Copy link
Member Author

jonespm commented Nov 22, 2024

Yes, this is still something we'd like.

In another project with the linked PR we used git rev-parse to save the version to a flat file during the build process. There's possibly other ways to accomplish this but this is the most straightforward. Most likely that script should also clean up the unnecessary git command after it's used.

@jadfalaoui
Copy link
Contributor

Hi @jonespm, I've been running tests for a few hours and there doesn't seem to be a point in the docker compose sequence where it is running inside a git repository, although it works when defining the environment variable before composing. I'm curious to know if this is the case in general or if my environment was set up incorrectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Effort: 4 Effort estimated at half-day good first issue Good for newcomers
Projects
Status: To Do
Development

No branches or pull requests

2 participants