Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clang: no member named 'allocate_tempblock' in 'bvector<A>' #76

Open
willdealtry opened this issue Jun 20, 2024 · 6 comments
Open

Clang: no member named 'allocate_tempblock' in 'bvector<A>' #76

willdealtry opened this issue Jun 20, 2024 · 6 comments

Comments

@willdealtry
Copy link

Hi there,

I'm a big fan of BitMagic and we use it in our database for a variety of things. I'm trying to build with Clang for the first time and I'm getting the error 'no member named 'allocate_tempblock' in 'bvector', same goes for 'free_tempblock'. I might be missing something stupid, but I can't actually see those methods being defined directly on the bvector, is there something I need to #define?

@willdealtry
Copy link
Author

It's related to the move constructor and move assignment in bulk_insert_iterator, if I comment those out everything works fine. Weirdly I can't work out why they were being moved anyway, I think Clang is doing something odd with lambda captures

@tlk00
Copy link
Owner

tlk00 commented Jul 7, 2024

Do you have a small code snippet for me to try? (I have clang on Mac).
Or maybe even a patch?

@yoshiF7d
Copy link

yoshiF7d commented Sep 3, 2024

I encountered the same problem. I tried to build ncbl blast from source with clang. this error occurred. google search lead me here. grep search tells that free_temblock is not defined anywhere. I don't know why it occures only with clang.
$grep free_tempblock -R src
src/bm.h: bvect_->free_tempblock(buf_);

@tlk00
Copy link
Owner

tlk00 commented Sep 3, 2024

I (think) I fixed the issue in the latest master branch.
Please pick the new version and try.
Master is supposed to be reasonable production grade at this point.

@yoshiF7d
Copy link

yoshiF7d commented Sep 6, 2024

Thank you very much. I dodged the problem by commenting out the move method. I hope the issue is now fixed.

@willdealtry
Copy link
Author

Excellent, thanks very much

vasil-pashov added a commit to man-group/ArcticDB that referenced this issue Nov 5, 2024
#### Reference Issues/PRs
Bitmagic is failing ArcitcDB builds. The issue is reported
[here](tlk00/BitMagic#76) and is fixed in
master. A ticket to port the fix into vcpkg is made
[here](microsoft/vcpkg#41935). Use custom
overlay while waiting for proper port.

#### What does this implement or fix?

#### Any other comments?

#### Checklist

<details>
  <summary>
   Checklist for code changes...
  </summary>
 
- [ ] Have you updated the relevant docstrings, documentation and
copyright notice?
- [ ] Is this contribution tested against [all ArcticDB's
features](../docs/mkdocs/docs/technical/contributing.md)?
- [ ] Do all exceptions introduced raise appropriate [error
messages](https://docs.arcticdb.io/error_messages/)?
 - [ ] Are API changes highlighted in the PR description?
- [ ] Is the PR labelled as enhancement or bug so it appears in
autogenerated release notes?
</details>

<!--
Thanks for contributing a Pull Request to ArcticDB! Please ensure you
have taken a look at:
- ArcticDB's Code of Conduct:
https://github.com/man-group/ArcticDB/blob/master/CODE_OF_CONDUCT.md
- ArcticDB's Contribution Licensing:
https://github.com/man-group/ArcticDB/blob/master/docs/mkdocs/docs/technical/contributing.md#contribution-licensing
-->
grusev pushed a commit to man-group/ArcticDB that referenced this issue Nov 25, 2024
#### Reference Issues/PRs
Bitmagic is failing ArcitcDB builds. The issue is reported
[here](tlk00/BitMagic#76) and is fixed in
master. A ticket to port the fix into vcpkg is made
[here](microsoft/vcpkg#41935). Use custom
overlay while waiting for proper port.

#### What does this implement or fix?

#### Any other comments?

#### Checklist

<details>
  <summary>
   Checklist for code changes...
  </summary>
 
- [ ] Have you updated the relevant docstrings, documentation and
copyright notice?
- [ ] Is this contribution tested against [all ArcticDB's
features](../docs/mkdocs/docs/technical/contributing.md)?
- [ ] Do all exceptions introduced raise appropriate [error
messages](https://docs.arcticdb.io/error_messages/)?
 - [ ] Are API changes highlighted in the PR description?
- [ ] Is the PR labelled as enhancement or bug so it appears in
autogenerated release notes?
</details>

<!--
Thanks for contributing a Pull Request to ArcticDB! Please ensure you
have taken a look at:
- ArcticDB's Code of Conduct:
https://github.com/man-group/ArcticDB/blob/master/CODE_OF_CONDUCT.md
- ArcticDB's Contribution Licensing:
https://github.com/man-group/ArcticDB/blob/master/docs/mkdocs/docs/technical/contributing.md#contribution-licensing
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants