Skip to content

Commit 28e0c93

Browse files
committed
Fixed the rest of the compiler type errors with the new version of actionbarsherlock (untested)
Conflicts: astrid/plugin-src/com/todoroo/astrid/tags/reusable/FeaturedTaskListFragment.java
1 parent 9786b11 commit 28e0c93

21 files changed

+79
-75
lines changed

actionbarsherlock/library/src/com/actionbarsherlock/app/SherlockListFragment.java

+10
Original file line numberDiff line numberDiff line change
@@ -59,10 +59,20 @@ public void onPrepareOptionsMenu(Menu menu) {
5959
public final boolean onOptionsItemSelected(android.view.MenuItem item) {
6060
return onOptionsItemSelected(new MenuItemWrapper(item));
6161
}
62+
63+
@Override
64+
public final boolean onContextItemSelected(android.view.MenuItem item) {
65+
return onContextItemSelected(new MenuItemWrapper(item));
66+
}
6267

6368
@Override
6469
public boolean onOptionsItemSelected(MenuItem item) {
6570
//Nothing to see here.
6671
return false;
6772
}
73+
74+
public boolean onContextItemSelected(MenuItem item) {
75+
//Nothing to see here.
76+
return false;
77+
}
6878
}

astrid/plugin-src/com/todoroo/astrid/actfm/ActFmLoginActivity.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
import android.graphics.PixelFormat;
2323
import android.os.Build;
2424
import android.os.Bundle;
25-
import android.support.v4.app.FragmentActivity;
2625
import android.text.InputType;
2726
import android.text.SpannableString;
2827
import android.text.Spanned;
@@ -41,6 +40,7 @@
4140
import android.widget.ScrollView;
4241
import android.widget.TextView;
4342

43+
import com.actionbarsherlock.app.SherlockFragmentActivity;
4444
import com.facebook.android.AsyncFacebookRunner;
4545
import com.facebook.android.AsyncFacebookRunner.RequestListener;
4646
import com.facebook.android.AuthListener;
@@ -97,7 +97,7 @@
9797
* @author Tim Su <[email protected]>
9898
*
9999
*/
100-
public class ActFmLoginActivity extends FragmentActivity implements AuthListener {
100+
public class ActFmLoginActivity extends SherlockFragmentActivity implements AuthListener {
101101

102102
public static final String APP_ID = "183862944961271"; //$NON-NLS-1$
103103

astrid/plugin-src/com/todoroo/astrid/actfm/CommentsActivity.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,12 @@
66
package com.todoroo.astrid.actfm;
77

88
import android.os.Bundle;
9-
import android.support.v4.app.ActionBar;
109
import android.support.v4.app.Fragment;
1110
import android.support.v4.app.FragmentTransaction;
12-
import android.support.v4.view.MenuItem;
1311
import android.widget.TextView;
1412

13+
import com.actionbarsherlock.app.ActionBar;
14+
import com.actionbarsherlock.view.MenuItem;
1515
import com.timsu.astrid.R;
1616
import com.todoroo.andlib.utility.AndroidUtilities;
1717
import com.todoroo.astrid.activity.AstridActivity;

astrid/plugin-src/com/todoroo/astrid/actfm/CommentsFragment.java

+6-6
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,10 @@
1313
import android.database.Cursor;
1414
import android.graphics.Bitmap;
1515
import android.os.Bundle;
16-
import android.support.v4.app.ActionBar;
17-
import android.support.v4.app.ListFragment;
18-
import android.support.v4.view.Menu;
19-
import android.support.v4.view.MenuItem;
2016
import android.text.Editable;
2117
import android.text.TextWatcher;
2218
import android.view.KeyEvent;
2319
import android.view.LayoutInflater;
24-
import android.view.MenuInflater;
2520
import android.view.MotionEvent;
2621
import android.view.View;
2722
import android.view.View.OnClickListener;
@@ -34,6 +29,11 @@
3429
import android.widget.TextView;
3530
import android.widget.TextView.OnEditorActionListener;
3631

32+
import com.actionbarsherlock.app.ActionBar;
33+
import com.actionbarsherlock.app.SherlockListFragment;
34+
import com.actionbarsherlock.view.Menu;
35+
import com.actionbarsherlock.view.MenuInflater;
36+
import com.actionbarsherlock.view.MenuItem;
3737
import com.timsu.astrid.R;
3838
import com.todoroo.andlib.service.Autowired;
3939
import com.todoroo.andlib.service.DependencyInjectionService;
@@ -50,7 +50,7 @@
5050
import com.todoroo.astrid.helper.ImageDiskCache;
5151
import com.todoroo.astrid.service.StatisticsService;
5252

53-
public abstract class CommentsFragment extends ListFragment {
53+
public abstract class CommentsFragment extends SherlockListFragment {
5454

5555
// private TagData tagData;
5656
protected UpdateAdapter updateAdapter;

astrid/plugin-src/com/todoroo/astrid/actfm/TagSettingsActivity.java

+5-5
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,6 @@
1616
import android.graphics.Bitmap;
1717
import android.graphics.Color;
1818
import android.os.Bundle;
19-
import android.support.v4.app.ActionBar;
20-
import android.support.v4.app.FragmentActivity;
21-
import android.support.v4.view.Menu;
22-
import android.support.v4.view.MenuItem;
2319
import android.text.TextUtils;
2420
import android.util.Log;
2521
import android.view.View;
@@ -31,6 +27,10 @@
3127
import android.widget.ImageView;
3228
import android.widget.TextView;
3329

30+
import com.actionbarsherlock.app.ActionBar;
31+
import com.actionbarsherlock.app.SherlockFragmentActivity;
32+
import com.actionbarsherlock.view.Menu;
33+
import com.actionbarsherlock.view.MenuItem;
3434
import com.timsu.astrid.R;
3535
import com.todoroo.andlib.data.TodorooCursor;
3636
import com.todoroo.andlib.service.Autowired;
@@ -70,7 +70,7 @@
7070
import com.todoroo.astrid.utility.ResourceDrawableCache;
7171
import com.todoroo.astrid.welcome.HelpInfoPopover;
7272

73-
public class TagSettingsActivity extends FragmentActivity {
73+
public class TagSettingsActivity extends SherlockFragmentActivity {
7474

7575
public static final String TOKEN_NEW_FILTER = "newFilter"; //$NON-NLS-1$
7676

astrid/plugin-src/com/todoroo/astrid/actfm/TagViewFragment.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@
1818
import android.content.Intent;
1919
import android.content.IntentFilter;
2020
import android.os.Bundle;
21-
import android.support.v4.view.Menu;
22-
import android.support.v4.view.MenuItem;
2321
import android.text.TextUtils;
2422
import android.util.DisplayMetrics;
2523
import android.view.MotionEvent;
@@ -32,6 +30,8 @@
3230
import android.widget.LinearLayout;
3331
import android.widget.TextView;
3432

33+
import com.actionbarsherlock.view.Menu;
34+
import com.actionbarsherlock.view.MenuItem;
3535
import com.timsu.astrid.R;
3636
import com.todoroo.andlib.data.TodorooCursor;
3737
import com.todoroo.andlib.service.Autowired;

astrid/plugin-src/com/todoroo/astrid/core/CustomFilterActivity.java

+6-6
Original file line numberDiff line numberDiff line change
@@ -22,20 +22,20 @@
2222
import android.graphics.drawable.BitmapDrawable;
2323
import android.os.Bundle;
2424
import android.os.Parcelable;
25-
import android.support.v4.app.ActionBar;
26-
import android.support.v4.app.FragmentActivity;
2725
import android.text.Editable;
2826
import android.text.TextWatcher;
2927
import android.util.Log;
3028
import android.view.ContextMenu;
3129
import android.view.ContextMenu.ContextMenuInfo;
32-
import android.view.MenuItem;
3330
import android.view.View;
3431
import android.view.View.OnCreateContextMenuListener;
3532
import android.widget.Button;
3633
import android.widget.ListView;
3734
import android.widget.TextView;
3835

36+
import com.actionbarsherlock.app.ActionBar;
37+
import com.actionbarsherlock.app.SherlockFragmentActivity;
38+
import com.actionbarsherlock.view.MenuItem;
3939
import com.timsu.astrid.R;
4040
import com.todoroo.andlib.data.Property.CountProperty;
4141
import com.todoroo.andlib.service.Autowired;
@@ -66,7 +66,7 @@
6666
* @author Tim Su <[email protected]>
6767
*
6868
*/
69-
public class CustomFilterActivity extends FragmentActivity {
69+
public class CustomFilterActivity extends SherlockFragmentActivity {
7070

7171
private static final String IDENTIFIER_TITLE = "title"; //$NON-NLS-1$
7272
private static final String IDENTIFIER_IMPORTANCE = "importance"; //$NON-NLS-1$
@@ -519,7 +519,7 @@ private <V> V getNth(int index, Map<?,V> map) {
519519
}
520520

521521
@Override
522-
public boolean onOptionsItemSelected(android.support.v4.view.MenuItem item) {
522+
public boolean onOptionsItemSelected(MenuItem item) {
523523
if (item.getItemId() == android.R.id.home) {
524524
finish();
525525
return true;
@@ -528,7 +528,7 @@ public boolean onOptionsItemSelected(android.support.v4.view.MenuItem item) {
528528
}
529529

530530
@Override
531-
public boolean onContextItemSelected(MenuItem item) {
531+
public boolean onContextItemSelected(android.view.MenuItem item) {
532532
if(item.getGroupId() == MENU_GROUP_FILTER) {
533533
// give an initial value for the row before adding it
534534
CustomFilterCriterion criterion = getNth(item.getItemId(), criteria);

astrid/plugin-src/com/todoroo/astrid/gtasks/GtasksListFragment.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@
99
import android.app.ProgressDialog;
1010
import android.content.Intent;
1111
import android.os.Bundle;
12-
import android.support.v4.view.Menu;
1312
import android.widget.TextView;
1413

14+
import com.actionbarsherlock.view.Menu;
1515
import com.timsu.astrid.R;
1616
import com.todoroo.andlib.data.Property;
1717
import com.todoroo.andlib.data.TodorooCursor;

astrid/plugin-src/com/todoroo/astrid/people/PersonViewFragment.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@
88
import android.app.Activity;
99
import android.content.ContentValues;
1010
import android.content.Intent;
11-
import android.support.v4.view.Menu;
1211
import android.text.TextUtils;
1312
import android.view.View;
1413
import android.view.ViewGroup;
1514
import android.widget.TextView;
1615

16+
import com.actionbarsherlock.view.Menu;
1717
import com.timsu.astrid.R;
1818
import com.todoroo.andlib.service.Autowired;
1919
import com.todoroo.andlib.utility.DateUtilities;

astrid/plugin-src/com/todoroo/astrid/tags/reusable/FeaturedTaskListFragment.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,15 @@
55
import android.content.Intent;
66
import android.content.res.Resources;
77
import android.graphics.Bitmap;
8-
import android.support.v4.view.Menu;
9-
import android.support.v4.view.MenuItem;
108
import android.text.TextUtils;
119
import android.view.ContextMenu;
1210
import android.view.ContextMenu.ContextMenuInfo;
1311
import android.view.View;
1412
import android.widget.TextView;
1513
import android.widget.Toast;
1614

15+
import com.actionbarsherlock.view.Menu;
16+
import com.actionbarsherlock.view.MenuItem;
1717
import com.timsu.astrid.R;
1818
import com.todoroo.andlib.data.TodorooCursor;
1919
import com.todoroo.andlib.service.Autowired;

astrid/plugin-src/com/todoroo/astrid/taskrabbit/TaskRabbitActivity.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,6 @@
3030
import android.os.Handler;
3131
import android.os.Message;
3232
import android.provider.Settings;
33-
import android.support.v4.app.ActionBar;
34-
import android.support.v4.app.FragmentActivity;
35-
import android.support.v4.view.MenuItem;
3633
import android.text.TextUtils;
3734
import android.text.method.LinkMovementMethod;
3835
import android.util.Log;
@@ -51,6 +48,9 @@
5148
import android.widget.PopupWindow.OnDismissListener;
5249
import android.widget.TextView;
5350

51+
import com.actionbarsherlock.app.ActionBar;
52+
import com.actionbarsherlock.app.SherlockFragmentActivity;
53+
import com.actionbarsherlock.view.MenuItem;
5454
import com.timsu.astrid.R;
5555
import com.todoroo.andlib.service.Autowired;
5656
import com.todoroo.andlib.service.DependencyInjectionService;
@@ -73,7 +73,7 @@
7373
import com.todoroo.astrid.ui.FragmentPopover;
7474
import com.todoroo.astrid.welcome.HelpInfoPopover;
7575

76-
public class TaskRabbitActivity extends FragmentActivity {
76+
public class TaskRabbitActivity extends SherlockFragmentActivity {
7777

7878

7979
public interface TaskRabbitSetListener {

astrid/plugin-src/com/todoroo/astrid/taskrabbit/TaskRabbitOAuthLoginActivity.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,11 @@
99
import android.content.Intent;
1010
import android.net.http.SslError;
1111
import android.os.Bundle;
12-
import android.support.v4.app.FragmentActivity;
1312
import android.webkit.SslErrorHandler;
1413
import android.webkit.WebView;
1514
import android.webkit.WebViewClient;
1615

16+
import com.actionbarsherlock.app.SherlockFragmentActivity;
1717
import com.timsu.astrid.R;
1818
import com.todoroo.andlib.service.Autowired;
1919
import com.todoroo.andlib.service.DependencyInjectionService;
@@ -28,7 +28,7 @@
2828
* @author timsu
2929
*
3030
*/
31-
public class TaskRabbitOAuthLoginActivity extends FragmentActivity {
31+
public class TaskRabbitOAuthLoginActivity extends SherlockFragmentActivity {
3232

3333
/**
3434
* URL to display

astrid/src/com/todoroo/astrid/activity/AddOnActivity.java

+5-5
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,15 @@
1212
import android.content.DialogInterface;
1313
import android.content.Intent;
1414
import android.os.Bundle;
15-
import android.support.v4.app.ActionBar;
16-
import android.support.v4.app.ActionBar.Tab;
17-
import android.support.v4.app.FragmentActivity;
1815
import android.support.v4.app.FragmentTransaction;
19-
import android.support.v4.view.MenuItem;
2016
import android.view.LayoutInflater;
2117
import android.view.View;
2218
import android.widget.ListView;
2319

20+
import com.actionbarsherlock.app.ActionBar;
21+
import com.actionbarsherlock.app.ActionBar.Tab;
22+
import com.actionbarsherlock.app.SherlockFragmentActivity;
23+
import com.actionbarsherlock.view.MenuItem;
2424
import com.timsu.astrid.R;
2525
import com.todoroo.andlib.service.Autowired;
2626
import com.todoroo.andlib.service.DependencyInjectionService;
@@ -37,7 +37,7 @@
3737
* @author Tim Su <[email protected]>
3838
*
3939
*/
40-
public class AddOnActivity extends FragmentActivity {
40+
public class AddOnActivity extends SherlockFragmentActivity {
4141

4242
/** boolean: whether to start on available page */
4343
public static final String TOKEN_START_WITH_AVAILABLE = "av"; //$NON-NLS-1$

astrid/src/com/todoroo/astrid/activity/AstridActivity.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,14 @@
1212
import android.os.Bundle;
1313
import android.speech.SpeechRecognizer;
1414
import android.support.v4.app.Fragment;
15-
import android.support.v4.app.FragmentActivity;
1615
import android.support.v4.app.FragmentManager;
1716
import android.support.v4.app.FragmentTransaction;
1817
import android.view.View;
1918
import android.view.WindowManager.BadTokenException;
2019
import android.widget.EditText;
2120
import android.widget.Toast;
2221

22+
import com.actionbarsherlock.app.SherlockFragmentActivity;
2323
import com.timsu.astrid.R;
2424
import com.todoroo.aacenc.RecognizerApi.RecognizerApiListener;
2525
import com.todoroo.andlib.service.Autowired;
@@ -60,7 +60,7 @@
6060
* @author Arne
6161
*
6262
*/
63-
public class AstridActivity extends FragmentActivity
63+
public class AstridActivity extends SherlockFragmentActivity
6464
implements FilterListFragment.OnFilterItemClickedListener,
6565
TaskListFragment.OnTaskListItemClickedListener,
6666
RecognizerApiListener {

astrid/src/com/todoroo/astrid/activity/FilterListFragment.java

+6-8
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,6 @@
1818
import android.graphics.Rect;
1919
import android.graphics.drawable.BitmapDrawable;
2020
import android.os.Bundle;
21-
import android.support.v4.app.Fragment;
22-
import android.support.v4.app.ListFragment;
23-
import android.support.v4.app.SupportActivity;
24-
import android.support.v4.view.Menu;
25-
import android.support.v4.view.MenuItem;
2621
import android.util.DisplayMetrics;
2722
import android.view.ContextMenu;
2823
import android.view.ContextMenu.ContextMenuInfo;
@@ -43,6 +38,9 @@
4338
import android.widget.TextView.OnEditorActionListener;
4439
import android.widget.Toast;
4540

41+
import com.actionbarsherlock.app.SherlockListFragment;
42+
import com.actionbarsherlock.view.Menu;
43+
import com.actionbarsherlock.view.MenuItem;
4644
import com.timsu.astrid.R;
4745
import com.todoroo.andlib.service.Autowired;
4846
import com.todoroo.andlib.service.DependencyInjectionService;
@@ -68,7 +66,7 @@
6866
* @author Tim Su <[email protected]>
6967
*
7068
*/
71-
public class FilterListFragment extends ListFragment {
69+
public class FilterListFragment extends SherlockListFragment {
7270

7371
public static final String TAG_FILTERLIST_FRAGMENT = "filterlist_fragment"; //$NON-NLS-1$
7472

@@ -115,7 +113,7 @@ public FilterListFragment() {
115113
}
116114

117115
@Override
118-
public void onAttach(SupportActivity activity) {
116+
public void onAttach(Activity activity) {
119117
super.onAttach(activity);
120118
// Check that the container activity has implemented the callback interface
121119
try {
@@ -395,7 +393,7 @@ public boolean onOptionsItemSelected(final MenuItem item) {
395393
return true;
396394
}
397395
default: {
398-
Fragment tasklist = getSupportFragmentManager().findFragmentByTag(TaskListFragment.TAG_TASKLIST_FRAGMENT);
396+
TaskListFragment tasklist = (TaskListFragment) getActivity().getSupportFragmentManager().findFragmentByTag(TaskListFragment.TAG_TASKLIST_FRAGMENT);
399397
if (tasklist != null && tasklist.isInLayout())
400398
return tasklist.onOptionsItemSelected(item);
401399
}

0 commit comments

Comments
 (0)