Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for addons to be in subdirectories #214

Open
karbassi opened this issue Aug 19, 2017 · 2 comments
Open

Allow for addons to be in subdirectories #214

karbassi opened this issue Aug 19, 2017 · 2 comments

Comments

@karbassi
Copy link
Member

karbassi commented Aug 19, 2017

It would be great to have action\PLUGIN_NAME\* as a structure so actions (add-ons) can be added in a clean structure without polluting the folder.

Personally, I use git submodule to structure the actions folder.

An example of something like this is how vim does plugins. See: vim-plug

@ginatrapani
Copy link
Member

Currently the few addons in the cli repo are in the addons branch; that's not ideal, and I honestly don't remember why I did it that way (it was a long time ago).

As a general guideline, I think addons should be in their own repositories, but I think the cli repo should have a few simple ones just as examples to other developers, which I think was my train of thought back in the day.

I'm fine with moving the addons in the addons branch to the master branch in their own folder and deleting that branch, okay by me.

@karbassi
Copy link
Member Author

The way the code works right now, if we do folders (as mentioned in the first post above), only the file with the same folder name will work.

For example:

$ tree edit

edit
├── e
└── edit

0 directories, 2 files

We'd want todo.sh edit and todo.sh e to work, correct? But that's not how it works.

$ todo.sh e

Usage: todo.sh [-fhpantvV] [-d todo_config] action [task_number] [task_description]
Try 'todo.sh -h' for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants