Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is_comparative() and is_superlative() missing #8

Open
lsmith77 opened this issue Oct 17, 2022 · 1 comment
Open

is_comparative() and is_superlative() missing #8

lsmith77 opened this issue Oct 17, 2022 · 1 comment

Comments

@lsmith77
Copy link

are these functions intentionally missing? or would you accept a PR adding these?

@tomaarsen
Copy link
Owner

They're not intentionally missing. I started work on these back in the day, but I believe I couldn't get good enough performance.
Another factor is that the project that inspired this one, https://metacpan.org/pod/Lingua::EN::Inflexion by Damian Conway, does not include converting to comparative and superlative. Those are features I added myself, and so I did not have a premade file of conversion rules and exceptions that I could base my work off, like I had for nouns and verbs.

I'd accept a PR for these, if you're willing to work on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants