Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checks to ensure robustness DICOM Attributes defined in multiple Modules #15

Open
tomaroberts opened this issue Aug 10, 2023 · 0 comments
Open

Add checks to ensure robustness DICOM Attributes defined in multiple Modules #15

tomaroberts opened this issue Aug 10, 2023 · 0 comments

Comments

@tomaroberts
Copy link
Owner

tomaroberts commented Aug 10, 2023 •
edited
Loading

Realised that some DICOM Attributes are defined in more than one Module, e.g.:

  • BitsAllocated is defined in both Image Pixel Module and MR Image Module

Current behaviour means that which ever Module is called second overrides. Not ideal.

TODO:

  • when calling Module subclasses, check if Attributes already exist in the Dicom object and then perform relevant logic, e.g. overwrite and warn.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomaroberts