-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR Smorgasbord #81
Comments
Thank you, I'll have a look in the following days! |
So, 1 and 2 can be merged I feel, you can open a PR with both. How are you achieving 3? I would like to see the code. Also, 3 and 4 can go into the same PR. I am not a huge fan of introducing a new feature with the need to opt-out and the nowebp tag, but perhaps it makes sense here. Again, feel free to open a PR for this. Also, the wiki needs to be updated, we can do it together, or even I could do it, after agreeing on the code and new tags. 5 could be merged, it needs a wiki update I feel. Is iceberg different than the current light nord theme? If so, you could add a new color scheme. 8 can be added, again with a wiki entry explaining how to use it. Not a huge fan of 6 and 9, I feel the first one could make the theme, but I don't like the UI, 9 is something I would never introduce, but I guess `typo-plus can take care of this use case. Finally, about the theme tweaks:
Thank you so much for all your work by the way, while some of those changes are a bit off my vision for the theme, others are really nice quality-of-life improvements and can be merged if you're willing to open the PRs. Also, it's a nice idea to have a |
I did not expect you to use all of the above changes, especially the ones that change the look&feel of the theme a lot. But I did want to give you the choice for it. 😄 Anything that won't end up in The above list is edited with PR links. I'm holding back on the For setting fonts, this might help. Instead of all fonts permanently living in the
|
I collected a long list of tweaks and improvements in a theme extension. Please pick whatever you want to have included from the list below and I'll open separate PRs for any of the chosen items, or subsets of those. Let me know if I can explain features in more detail. I might need your help if you want to have things optional or configurable in the
hugo.toml
.fix nestedPR: fix nested ul/ol/li spacing #83ul
/ol
/li
spacing https://ole.mn/posts/markdown_showcase/#lists (scroll down a bit)fix reflow of header linksPR: prevent linebreaks in header words for small window sizes #84/home /posts /etc.
: narrow your browser window to seefix image renderingPR: Image optimization #87webp
(overridable)introduce more image tags, combine with #small and #fullmake mermaid colorschemes configurable for light and dark modePR: Configure mermaid theme #86set in hugo.tomlswitches (reinitializes) with light/dark theme changeadd manicule shortcode https://ole.mn/posts/markdown_showcase/#maniculesPR: add manicule shortcode #82font-independent SVGcolored by var(--content-primary)switches with theme»
design element before (non h1) headings for better readabilityline-summary
color links with var(--content-secondary) on hoverPR: add var(--content-secondary) color to links on hover #85The text was updated successfully, but these errors were encountered: