Provide support for specifying a metrics namespace

[tomkerkhove]

Proposal

Provide support for specifying a metrics namespace so that you can choose which one to use in case the provider supports it.

One example is Azure Application Insights that allows you to query the default metrics or custom ones which use azure.applicationinsights as metric namespace.

Component

Scraper

Contact Details

No response

[tomkerkhove]

When getting all metric definitions, we should add the metric namespace to it:

promitor/src/Promitor.Integrations.AzureMonitor/AzureMonitorClient.cs

Lines 74 to 76 in 5b3c4b5

	var metricsDefinitions = await _authenticatedAzureSubscription.MetricDefinitions.ListByResourceAsync(resourceId);
	var metricDefinition = metricsDefinitions.SingleOrDefault(definition => definition.Name.Value.ToUpper() == metricName.ToUpper());
	if (metricDefinition == null)

We have to extend our query to call .FilterByNamespace(<name>), when configured:

promitor/src/Promitor.Integrations.AzureMonitor/AzureMonitorClient.cs

Lines 203 to 207 in 5b3c4b5

	var metricQuery = metricDefinition.DefineQuery()
	.StartingFrom(recordDateTime.AddDays(-5))
	.EndsBefore(recordDateTime)
	.WithAggregation(metricAggregation.ToString())
	.WithInterval(metricsInterval);

[bogdansandu]

Hei,
Any update on this feature?
I need to use it for exactly this scenario you described (metrics from application insights, custom namespace).
Thank you!

[tomkerkhove]

Not yet as I've hit a limitation but looking for alternatives.

Sorry for the delay.

[marevers]

Is this feature still planned? We are looking for a way to scrape VM guest metrics with Promitor but seeing as those are in a different metrics namespace, for now there does not seem to be a way to do that.

[tomkerkhove]

This is definately still planned but hasn't been implemented yet. Are you open to taking a stab at this?

[marevers]

This is definately still planned but hasn't been implemented yet. Are you open to taking a stab at this?

Unfortunately, I do not really know my way around C# so this would be difficult for me to do.

[tomkerkhove]

No problem at all!

[MisterVVP]

Hi @tomkerkhove, I'm currently debugging this locally. Do you remember what was the problem you hit here? I have grabbed your commits and rebased from master, things seem to work with your commits

Any tips?

[tomkerkhove]

From what I recall, custom metric is not supported by using these APIs. But it's been a while so that might have changed.