-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
are you doing scan-matching? #3
Comments
Thank you for the thorough answer :) When you say, "while I only implement the original version of RBPF that adopt the motion model as the proposal distribution"?. Does this original implementation lack scan-matching? 🤔 I still don't understand if you have implemented the scan matching or not, at least I'm unable to identify anything resembles an ICP or HectorSLAM algorithm in your code. |
I only utilize motion model as the proposal distribution and do not apply the scan matching. |
First of all, great project you have here :) I'm assuming you have based your implementation on the paper Improved Techniques for Grid Mapping With Rao-Blackwellized Particle Filters, is that correct? When reading through your code I couldn't identify which part of the code that was doing scan-matching. Is it included in the implementation, if so, which part of the code is this? The only possible candidate I found was this.
It seems to me that this part of the corresponds to step 3 and 4 in the algorithm in the paper, meaning that you first do a sampling step, then you compute an improved proposal distribution and then you update importance weights. It also looks like you're skipping the scan-matching, is that correct? Also, you have commented out the resampling, why is that?
Sorry for all the questions, I'm just curious on your implementation :) I tried to run your code, and it works great, so kudos for that!
The text was updated successfully, but these errors were encountered: