Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retain PREINITDEVICE during A-only addon.d #7284

Merged
merged 1 commit into from
Sep 24, 2023
Merged

Retain PREINITDEVICE during A-only addon.d #7284

merged 1 commit into from
Sep 24, 2023

Conversation

osm0sis
Copy link
Collaborator

@osm0sis osm0sis commented Sep 1, 2023 •
edited
Loading

Just realized this was missing from our recovery dirty flash PREINITDEVICE support!

@osm0sis
Copy link
Collaborator Author

osm0sis commented Sep 2, 2023 •
edited
Loading

Adjusted the restore placement to be before the sleep 5 to ensure there aren't any potential timing issues that could result in config.orig getting removed beforehand.

Should be good to go now! 👍

@osm0sis
Copy link
Collaborator Author

osm0sis commented Sep 4, 2023 •
edited
Loading

@topjohnwu This should have been merged before stable to avoid loss in function for A-only custom ROM users... 🫤

@topjohnwu topjohnwu merged commit 9b3896f into master Sep 24, 2023
8 checks passed
@topjohnwu topjohnwu deleted the fix/addond-preinit branch September 24, 2023 06:51
@opusforlife2
Copy link

loss in function for A-only custom ROM

I JUST installed 26.3 on such a device. What do I need to be careful about?

@osm0sis
Copy link
Collaborator Author

osm0sis commented Oct 29, 2023

I JUST installed 26.3 on such a device. What do I need to be careful about?

Install latest canary in a recovery and you're fine.

@opusforlife2
Copy link

Alright. Is it okay to go back to 26.1 though? I would much prefer staying on stable.

@osm0sis
Copy link
Collaborator Author

osm0sis commented Oct 29, 2023 •
edited
Loading

Alright. Is it okay to go back to 26.1 though? I would much prefer staying on stable.

Not a good idea. Old stable had issues which is why there is a newer stable. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@topjohnwu topjohnwu topjohnwu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@osm0sis @opusforlife2 @topjohnwu