-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor for wgpu v23 compatibility #2435
base: main
Are you sure you want to change the base?
Refactor for wgpu v23 compatibility #2435
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2435 +/- ##
=======================================
Coverage 81.86% 81.86%
=======================================
Files 833 833
Lines 106449 106448 -1
=======================================
Hits 87146 87146
+ Misses 19303 19302 -1 ☔ View full report in Codecov by Sentry. |
* The comments in `WgpuDevice::id()` are removed since `id` in `WgpuDevice::Existing` is always `u32`
DiscoveryThe least recent version of |
This comment has been minimized.
This comment has been minimized.
Status UpdateCurrently, I am busy working at my personal projects. I would run CI every one or two weeks. It seems that there are more errors occurred on macOS. I would resolve them after I finish my own works. |
SSIM on wasm causes bad glitches. I suspect it's related to tracel-ai/burn#2435, but hard to say.
SSIM on wasm causes bad glitches. I suspect it's related to tracel-ai/burn#2435, but hard to say.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
That's awesome! Thanks for checking again :) I think the remaining errors are the same as here: #2539 The deformable convolutions might need some attention from Genna, for the others, maybe @nathanielsimard knows? |
994373b
to
43b6d32
Compare
43b6d32
to
1d8b131
Compare
It just passed CI 20 hours ago ... And macOS failed at 110+ tests? I think I am using the right CubeCL version. |
Checklist
run-checks all
script has been executed.contributor-book/src/guides/adding-a-new-operation-to-burn.md
needs to be updated.Related Issues/PRs
Close #2451
Changes
cubecl
to tracel-ai/cubecl@13fc62cwgpu
to23.0.0
WgpuDevice::id()
inburn-tensor
Testing
(Solved): I run
./run-checks.sh all
, but too many errors occurred on macOS (Metal) 🥺. Fixing the bugs ...