-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor for wgpu v23 compatibility with an example of wgpu device sharing #211
Refactor for wgpu v23 compatibility with an example of wgpu device sharing #211
Conversation
* Change type of `entry_point` from `&str` to `Option<&str>` * Change enum type of `WgpuDevice::Existing` from `wgpu::Id<wgpu::Device>` to `usize`
* Added auto-increment counter in init_existing_device * Added comments of usage
fcb6085
to
dd04e6c
Compare
* Also updated an argument, see https://docs.rs/wgpu-hal/latest/wgpu_hal/vulkan/struct.Adapter.html#method.device_from_raw
In theory now that the OOB behaviour has been fixed this should work now, if you have time to re test on metal would be amazing :) Thank you! |
This comment has been minimized.
This comment has been minimized.
I don't think the CI is building CUDA. |
@AsherJingkongChen If you merge main, does it fix the CI? |
I don't get it why did it pass CI. I just updated feature flags. LOL. |
This is because the CI errors was caused by the |
Related Issues/PRs
Checklist
cargo xtask test --ci
script has been executed.Changes
1. Modified
entry_point
Typeentry_point
from&str
toOption<&str>
.2. Updated
WgpuDevice::Existing
Enum TypeWgpuDevice::Existing
fromwgpu::Id<wgpu::Device>
tou32
.wgpu::Id
no longer exists. Using au32
ensures a unique identifier forWgpuDevice::Existing
.Examples
device_sharing
Example