Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample data parameter to Metadata, add humanize for readable window size #178

Merged
merged 2 commits into from
Dec 26, 2023

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Dec 26, 2023

Closes #177
Closes #176

@gsheni gsheni self-assigned this Dec 26, 2023
Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (61cefb0) 84.28% compared to head (5e6f90e) 84.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
+ Coverage   84.28%   84.38%   +0.10%     
==========================================
  Files          29       29              
  Lines        1368     1377       +9     
==========================================
+ Hits         1153     1162       +9     
  Misses        215      215              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gsheni gsheni marked this pull request as ready for review December 26, 2023 16:16
@gsheni gsheni changed the title xadded humanize Add sample data parameter to Metadata, add humanize for readble window size Dec 26, 2023
@gsheni gsheni changed the title Add sample data parameter to Metadata, add humanize for readble window size Add sample data parameter to Metadata, add humanize for readable window size Dec 26, 2023
@gsheni gsheni merged commit 41539cb into main Dec 26, 2023
13 checks passed
@gsheni gsheni deleted the add_sample_data_check branch December 26, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add humanize to parse window_size into more readable format Add foreign key tags if normalized
1 participant