Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: Granular function selection /w update interval settings #355

Open
1 task
V4ler1an opened this issue Jan 3, 2025 · 2 comments
Open
1 task

[FR]: Granular function selection /w update interval settings #355

V4ler1an opened this issue Jan 3, 2025 · 2 comments
Labels
feature request Request for a new feature or enhancement

Comments

@V4ler1an
Copy link
Contributor

V4ler1an commented Jan 3, 2025

Describe the new feature or enhancement idea

My OPNsense integration pulls down 385 entities although I currently have 42 enabled and in use. Debug logs report each update taking over 5 seconds. To reduce possible security risks i've also only enabled API privileges for the specific functions I need and use. The logs contain a lot of permissions errors and time spent trying to collect information I don't require.

In Home Assistant, some of the entities are valuable to have updated more frequently for say dashboard status updates or time sensitive automations triggered from changes to said status info. But many don't require this.

Given the size of the integration, I feel it would be beneficial if its configuration offered a toggle list to enable or disable the functional areas that are needed. Additionally, independent refresh intervals would reduce unnecessary updating overhead and allow for more frequent updates where useful.

I'd like to know your thoughts about these enhancements. Many thanks!

Will you be building this?

  • I intend to submit a PR to implement this

Additional Details

No response

@V4ler1an V4ler1an added the feature request Request for a new feature or enhancement label Jan 3, 2025
@V4ler1an V4ler1an changed the title [FR]: Granular function selection /w update interval setting [FR]: Granular function selection /w update interval settings Jan 3, 2025
@Snuffy2
Copy link
Collaborator

Snuffy2 commented Jan 6, 2025

Yeah, I generally agree that doing something like you describe makes sense. It is doable.

Unsurprisingly, it is a big code overhaul. I feel like I only just finished the recent rewrite so I'm not sure I'm motivated to work on this right now.

Happy to review PRs from anyone who is interested and/or I'll likely get to this at some point.

@V4ler1an
Copy link
Contributor Author

V4ler1an commented Jan 6, 2025

That's understandable. Thank you for all the great work you've done on this integration, it's made a huge difference!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants