Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Passphrase wallet in wallet/device selector #15579

Closed
bosomt opened this issue Nov 26, 2024 · 7 comments · Fixed by #16909
Closed

Missing Passphrase wallet in wallet/device selector #15579

bosomt opened this issue Nov 26, 2024 · 7 comments · Fixed by #16909
Assignees
@peter-sanderson
Labels
bug Something isn't working as expected

Comments

@bosomt
Copy link
Contributor

bosomt commented Nov 26, 2024

Describe the bug
Missing Passphrase wallet in wallet/device selector there is just * present
Labeling is disabled

Steps to reproduce:

  1. Add standard wallet
  2. Add passphrase wallet
  3. Open wallet selector

Info:

  • Suite version: web 24.12.0 (d29333b)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/131.0.0.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T3T1 2.8.3 regular (revision 7f373ae71eca855dd41b4a0fdcc7cadaa13a8281)
  • Transport: WebUsbTransport

Screenshots:
image
@github-project-automation github-project-automation bot moved this to 🎯 To do in Suite Desktop Nov 26, 2024
@bosomt bosomt added the bug Something isn't working as expected label Nov 26, 2024
@bosomt
Copy link
Contributor Author

bosomt commented Dec 2, 2024

Its easy to double your wallets, see videos i just took on production wallet
Maybe this can be causing problems that users are reporting @MiroslavProchazka @komret

Screen.Recording.2024-12-02.at.16.18.59.mov
Screen.Recording.2024-12-02.at.16.20.13.mov

@komret
Copy link
Contributor

komret commented Jan 8, 2025 •
edited
Loading

I could not reproduce. Perhaps before device selector does not open during discovery? Please reopen if still valid.

Image

@komret komret closed this as completed Jan 8, 2025
@github-project-automation github-project-automation bot moved this from 🎯 To do to 🤝 Needs QA in Suite Desktop Jan 8, 2025
@bosomt
Copy link
Contributor Author

bosomt commented Jan 13, 2025

Its kinda easy to reproduce
stared Standard wallet disocvery and pressed command + p
It generated two more wallets without any passphrase dialogue ;)

reopen ?

Image

Info:

  • Suite version: web 25.2.0 (cb71804)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/131.0.0.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T3T1 2.8.7 regular (revision 8a254aa8eae82f99630df63f40e4d290066a3efc)
  • Transport: BridgeTransport 3.0.0-bundled.25.1.1

@STew790 STew790 reopened this Jan 21, 2025
@github-project-automation github-project-automation bot moved this from 🤝 Needs QA to 🎯 To do in Suite Desktop Jan 21, 2025
@peter-sanderson
Copy link
Contributor

peter-sanderson commented Feb 10, 2025 •
edited
Loading

My findings:

  • You shall NOT add wallet or even open wallet switcher during discovery
  • It is deliberately disable in the UI
  • => we shall disabled the ALT+P keybind as well

@peter-sanderson peter-sanderson mentioned this issue Feb 10, 2025
Merged
@peter-sanderson
Copy link
Contributor

@bosomt / @STew790 are you able to reproduce this without the CMD+P / ALT+P keybind?

@peter-sanderson peter-sanderson self-assigned this Feb 10, 2025
@peter-sanderson peter-sanderson moved this from 🎯 To do to 🏃‍♀️ In progress in Suite Desktop Feb 10, 2025
@bosomt
Copy link
Contributor Author

bosomt commented Feb 10, 2025

@peter-sanderson im not able to reproduce it without shortcut

@github-project-automation github-project-automation bot moved this from 🏃‍♀️ In progress to 🤝 Needs QA in Suite Desktop Feb 12, 2025
@bosomt bosomt moved this from 🤝 Needs QA to ✅ Approved in Suite Desktop Feb 12, 2025
@bosomt
Copy link
Contributor Author

bosomt commented Feb 12, 2025

QA OK

  • i was not able to reproduce it anymore ✅
  • i was not able to open device/wallet selector during discovery

Info:

  • Suite version: web 25.3.0 (7282d84)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/133.0.0.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1470x956
  • Device: Trezor T2T1 2.8.8 regular (revision 592590cf66a9b62dfeee7e4d2afb6e01005e5b2c)
  • Transport: WebUsbTransport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peter-sanderson peter-sanderson

Labels
bug Something isn't working as expected
Projects
Suite Desktop
Status: ✅ Approved
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: disable keybinds or wallet switcher during discovery trezor/trezor-suite
4 participants
@bosomt @komret @STew790 @peter-sanderson