Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile: XRP destination tag improvement #16636

Closed
vytick opened this issue Jan 27, 2025 · 2 comments · Fixed by #16915
Closed

Mobile: XRP destination tag improvement #16636

vytick opened this issue Jan 27, 2025 · 2 comments · Fixed by #16915
Assignees
@vytick
Labels
mobile Suite Lite issues and PRs QA OK Issue passed QA without any blocker Ripple XRP

Comments

@vytick
Copy link
Contributor

vytick commented Jan 27, 2025 •
edited
Loading

Improve UI for XRP destination tag.

  • add toggle that is enabled by default for Ripple (XRP)
  • enabled toggle shows destination tag and makes it required to be set in order to proceed
  • show warning otherwise
  • show info alert in receive for ripple

design in figma
@vytick vytick added design needed Development is blocked by lack of design mobile Suite Lite issues and PRs labels Jan 27, 2025
@github-project-automation github-project-automation bot moved this to 🎯 To do in Suite Mobile Jan 27, 2025
@vytick vytick added Ripple XRP and removed design needed Development is blocked by lack of design labels Jan 30, 2025
@matejkriz
Copy link
Member

We need to fix this bug too #16697 otherwise it can be hidden behind the keyboard...

@vytick vytick self-assigned this Feb 10, 2025
@vytick vytick moved this from 🎯 To do to 🏃‍♀️ In progress in Suite Mobile Feb 10, 2025
@vytick vytick mentioned this issue Feb 11, 2025
Merged
@vytick vytick moved this from 🏃‍♀️ In progress to 🤝 Needs QA in Suite Mobile Feb 11, 2025
@STew790
Copy link
Contributor

STew790 commented Feb 11, 2025

QA OK

  • toggle enabled by default
  • tag is required (there's no "Send" button if it is not filled in)
  • warning shown when tag disabled
  • alert in "Receive" present

Image

Image

Image

Image

Info
25.2.1 8c07184

@STew790 STew790 moved this from 🤝 Needs QA to ✅ Approved in Suite Mobile Feb 11, 2025
@STew790 STew790 added the QA OK Issue passed QA without any blocker label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vytick vytick

Labels
mobile Suite Lite issues and PRs QA OK Issue passed QA without any blocker Ripple XRP
Projects
Suite Mobile
Status: ✅ Approved
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

request Destination tag for ripple trezor/trezor-suite
3 participants
@vytick @matejkriz @STew790