Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate trade contexts with redux state in suite-common #16518

Open
vytick opened this issue Jan 21, 2025 · 0 comments · May be fixed by #16866
Open

Duplicate trade contexts with redux state in suite-common #16518

vytick opened this issue Jan 21, 2025 · 0 comments · May be fixed by #16866
Assignees
@adderpositive
Labels
+Invity Related to Invity project mobile Suite Lite issues and PRs

Comments

@vytick
Copy link
Contributor

vytick commented Jan 21, 2025 •
edited
Loading

In desktop app, trading state is vastly saved in context. Duplicate the functionality, but have data stored in redux instead of context in suite-common.

Do not replace the code in the Suite, just start making a clone using redux instead of context

⚠ Increased test coverage for trade functionality is needed before we can proceed with replacing the code in Suite.
@vytick vytick added +Invity Related to Invity project blocked Blocked by external force. Third party inputs required. mobile Suite Lite issues and PRs labels Jan 21, 2025
@github-project-automation github-project-automation bot moved this to 🎯 To do in Suite Mobile Jan 21, 2025
@vytick vytick changed the title Refactor desktop coinmarket contexts into redux state Refactor desktop trade contexts into redux state Jan 22, 2025
@vytick vytick removed this from Suite Mobile Jan 22, 2025
@vytick vytick removed the blocked Blocked by external force. Third party inputs required. label Jan 24, 2025
@github-project-automation github-project-automation bot moved this to 🎯 To do in Suite Mobile Jan 24, 2025
@vytick vytick changed the title Refactor desktop trade contexts into redux state Duplicate trade contexts with redux state in suite-common Jan 24, 2025
@adderpositive adderpositive self-assigned this Feb 6, 2025
@adderpositive adderpositive linked a pull request Feb 6, 2025 that will close this issue
Draft
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adderpositive adderpositive

Labels
+Invity Related to Invity project mobile Suite Lite issues and PRs
Projects
Suite Mobile
Status: 🎯 To do
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(trading): move buy trading part to suite-common trezor/trezor-suite
2 participants
@vytick @adderpositive