Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(suite-native): develop build pipeline fix #16918

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

PeKne
Copy link
Contributor

@PeKne PeKne commented Feb 11, 2025

@PeKne PeKne added the mobile Suite Lite issues and PRs label Feb 11, 2025
@PeKne PeKne requested a review from vdovhanych as a code owner February 11, 2025 11:04
Copy link

coderabbitai bot commented Feb 11, 2025

Walkthrough

The pull request updates the build workflow configuration by specifying a fixed version of Expo Application Services (EAS) for the native build process. The configuration no longer uses the dynamic "latest" value and now explicitly sets eas-version to "14.7.1". This update affects the setup step during the build job while the overall workflow structure, including conditions for job execution, environment settings, and multi-platform build steps for Android and iOS, remains unchanged. No modifications were made to the declarations of exported or public entities.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b5261d9 and bfbbed9.

📒 Files selected for processing (1)
  • .github/workflows/release-suite-native-develop.yml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/release-suite-native-develop.yml
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Setup and Cache Dependencies
  • GitHub Check: Analyze with CodeQL (javascript)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 65583b2 and b5261d9.

📒 Files selected for processing (1)
  • .github/workflows/release-suite-native-develop.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Setup and Cache Dependencies
  • GitHub Check: Analyze with CodeQL (javascript)

@@ -30,7 +30,7 @@ jobs:
- name: Setup EAS
uses: expo/expo-github-action@v8
with:
eas-version: latest
eas-version: 14.7.1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

LGTM! Fixed EAS version improves build stability.

Pinning the EAS version to 14.7.1 instead of using 'latest' is a good practice as it:

  • Ensures consistent builds across different environments
  • Prevents unexpected breaking changes from newer versions
  • Makes builds more reproducible and debuggable

Let's verify this version matches PR #16887:


🏁 Script executed:

#!/bin/bash
# Description: Check if EAS version is consistent with PR #16887
git fetch origin pull/16887/head:pr-16887
git show pr-16887:.github/workflows/release-suite-native-develop.yml | grep 'eas-version'

Length of output: 263


EAS Version Discrepancy Detected
The EAS version in the current branch is set to 14.7.1, while PR #16887 still uses latest. This misalignment means the current change does not match the referenced PR. Please confirm if the intentional improvement to pin the version at 14.7.1 should override the settings in PR #16887 or if further adjustments are needed.

@PeKne PeKne enabled auto-merge (rebase) February 11, 2025 11:10
Copy link
Contributor

@vytick vytick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

- Apply the same eas version to develop builds as this PR did to other tracks: #16887
@PeKne PeKne force-pushed the fix/native/develop-build-pipeline branch from b072a6a to bfbbed9 Compare February 11, 2025 11:15
@PeKne PeKne merged commit 1e9a125 into develop Feb 11, 2025
12 checks passed
@PeKne PeKne deleted the fix/native/develop-build-pipeline branch February 11, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Suite Lite issues and PRs
Projects
Status: 🎯 To do
Development

Successfully merging this pull request may close these issues.

3 participants