-
-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(suite-native): develop build pipeline fix #16918
Conversation
PeKne
commented
Feb 11, 2025
- Apply the same eas version to develop builds as this PR did to other tracks: Fix EAS builds by downgrading eas-cli to 14.7 fixed version #16887
WalkthroughThe pull request updates the build workflow configuration by specifying a fixed version of Expo Application Services (EAS) for the native build process. The configuration no longer uses the dynamic "latest" value and now explicitly sets 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/release-suite-native-develop.yml
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Setup and Cache Dependencies
- GitHub Check: Analyze with CodeQL (javascript)
@@ -30,7 +30,7 @@ jobs: | |||
- name: Setup EAS | |||
uses: expo/expo-github-action@v8 | |||
with: | |||
eas-version: latest | |||
eas-version: 14.7.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
LGTM! Fixed EAS version improves build stability.
Pinning the EAS version to 14.7.1 instead of using 'latest' is a good practice as it:
- Ensures consistent builds across different environments
- Prevents unexpected breaking changes from newer versions
- Makes builds more reproducible and debuggable
Let's verify this version matches PR #16887:
🏁 Script executed:
#!/bin/bash
# Description: Check if EAS version is consistent with PR #16887
git fetch origin pull/16887/head:pr-16887
git show pr-16887:.github/workflows/release-suite-native-develop.yml | grep 'eas-version'
Length of output: 263
EAS Version Discrepancy Detected
The EAS version in the current branch is set to 14.7.1, while PR #16887 still uses latest. This misalignment means the current change does not match the referenced PR. Please confirm if the intentional improvement to pin the version at 14.7.1 should override the settings in PR #16887 or if further adjustments are needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
- Apply the same eas version to develop builds as this PR did to other tracks: #16887
b072a6a
to
bfbbed9
Compare