Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook update 8.5.4 #16929

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from
Draft

Storybook update 8.5.4 #16929

wants to merge 6 commits into from

Conversation

vojtatranta
Copy link
Contributor

Description

Related Issue

Resolve

Screenshots:

framework: {
name: getAbsolutePath('@storybook/react-webpack5'),
name: getAbsolutePath('@storybook/nextjs'),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also automigrate, it works with it tho


// Configure SVG files to match the main project's webpack config
config.module.rules.push({
test: /\.(gif|jpe?g|png|svg)$/,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the same config we have in the proejct and with it, it laods the coin icons properly

</>
);
export const StoryWrapper = (story: any) =>
React.createElement(Fragment, null,
Copy link
Contributor Author

@vojtatranta vojtatranta Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Storybook had troubles running the JSX so I did this, I am not sure if it is a porlbme or not, I can tweak it to eat the JSX "in config"

Copy link

socket-security bot commented Feb 11, 2025

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Trivial Package npm/[email protected] 🚫
Network access npm/[email protected] 🚫
Shell access npm/[email protected] 🚫
Deprecated npm/[email protected]
  • Reason: this will be v4
🚫
Uses eval npm/[email protected] 🚫

View full report↗︎

Next steps

What are trivial packages?

Packages less than 10 lines of code are easily copied into your own project and may not warrant the additional supply chain risk of an external dependency.

Removing this package as a dependency and implementing its logic will reduce supply chain risk.

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

What is shell access?

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.

What is a deprecated package?

The maintainer of the package marked it as deprecated. This could indicate that a single version should not be used, or that the package is no longer maintained and any new vulnerabilities will not be fixed.

Research the state of the package and determine if there are non-deprecated versions that can be used, or if it should be replaced with a new, supported solution.

What is dynamic code execution?

Package uses dynamic code execution (e.g., eval()), which is a dangerous practice. This can prevent the code from running in certain environments and increases the risk that the code may contain exploits or malicious behavior.

Avoid packages that use dynamic code execution like eval(), since this could potentially execute any code.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

Copy link

github-actions bot commented Feb 11, 2025

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 26
  • More info

Learn more about 𝝠 Expo Github Action

@vojtatranta vojtatranta force-pushed the storybook-update-8.5.4 branch 2 times, most recently from 6247ba3 to 35a2234 Compare February 11, 2025 13:27
@vojtatranta
Copy link
Contributor Author

Damned storybook , it updated ton of dependencies and the yarn lock as well and now it breaks trillion of things.

@vojtatranta vojtatranta force-pushed the storybook-update-8.5.4 branch 6 times, most recently from cb21ff1 to b1e4f28 Compare February 12, 2025 13:41
@vojtatranta
Copy link
Contributor Author

Okay, I am in the stage when nothing crashes like hell, the types are fixed. I went through the c hanges in the stories and it seems that the components controls work. But more eyes see more @jvaclavik would you check pls?

@vojtatranta
Copy link
Contributor Author

@Nodonisko ask about the package updates

Copy link
Contributor

@jvaclavik jvaclavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! ☀️

@vojtatranta vojtatranta force-pushed the storybook-update-8.5.4 branch 2 times, most recently from 0db0a6e to 3812b75 Compare February 13, 2025 14:29
@vojtatranta vojtatranta force-pushed the storybook-update-8.5.4 branch from 3812b75 to bd314b8 Compare February 13, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🤝 Needs QA
Development

Successfully merging this pull request may close these issues.

2 participants