fix(suite): Fix non-ascii banner in passphrase wallet

[jvaclavik]

Description

dark mode problem only

Related Issue

Resolve

Screenshots:

before

after

[coderabbitai]

Walkthrough

The changes update the styling properties of the SpecialChars component within the NonAsciiBanner.tsx file. The box-shadow property has been modified from inset 0 0 0 2px #f2f2f2 to inset 0 0 0 1px ${({ theme }) => theme.borderElevation0}, resulting in a reduction of shadow thickness and a dynamic value based on the theme. The border-radius property has been updated to include a top border radius of ${borders.radii.xs} for the top-left and top-right corners. Additionally, a new padding-bottom property has been added with a value of ${spacingsPx.xxxs} to adjust the spacing at the bottom of the SpecialChars component. No alterations have been made to the declarations of exported or public entities.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b2a8652 and 1031f69.

📒 Files selected for processing (1)

• packages/product-components/src/components/PassphraseTypeCard/NonAsciiBanner.tsx (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• packages/product-components/src/components/PassphraseTypeCard/NonAsciiBanner.tsx

⏰ Context from checks skipped due to timeout of 90000ms (9)

• GitHub Check: run-desktop-tests (@group=wallet, trezor-user-env-unix bitcoin-regtest)
• GitHub Check: run-desktop-tests (@group=other, trezor-user-env-unix)
• GitHub Check: run-desktop-tests (@group=settings, trezor-user-env-unix bitcoin-regtest)
• GitHub Check: run-desktop-tests (@group=device-management, trezor-user-env-unix)
• GitHub Check: build-web
• GitHub Check: build-web
• GitHub Check: Setup and Cache Dependencies
• GitHub Check: Analyze with CodeQL (javascript)
• GitHub Check: run-desktop-tests (@group=suite, trezor-user-env-unix)

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

packages/product-components/src/components/PassphraseTypeCard/NonAsciiBanner.tsx (2)

28-30: LGTM! The styling changes effectively address the dark mode issue.

The changes improve the banner's appearance by:

• Using theme-based colors for better dark mode support
• Adding rounded top corners for visual hierarchy
• Improving spacing with consistent padding

Consider using theme tokens for border width.

For better maintainability and consistency, consider extracting the 1px border width to a theme token.

-    box-shadow: inset 0 0 0 1px ${({ theme }) => theme.borderElevation0};
+    box-shadow: inset 0 0 0 ${({ theme }) => theme.borderWidths.normal} ${({ theme }) => theme.borderElevation0};

---

68-68: Address the TODO comment about reusing LearnMoreButton.

The comment suggests using a reusable LearnMoreButton component instead of the current implementation. This would improve code consistency and maintainability.

Would you like me to help implement this change by generating the code to use the LearnMoreButton component?

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 246db18 and b2a8652.

📒 Files selected for processing (1)

• packages/product-components/src/components/PassphraseTypeCard/NonAsciiBanner.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (9)

• GitHub Check: run-desktop-tests (@group=wallet, trezor-user-env-unix bitcoin-regtest)
• GitHub Check: run-desktop-tests (@group=other, trezor-user-env-unix)
• GitHub Check: run-desktop-tests (@group=settings, trezor-user-env-unix bitcoin-regtest)
• GitHub Check: run-desktop-tests (@group=device-management, trezor-user-env-unix)
• GitHub Check: run-desktop-tests (@group=suite, trezor-user-env-unix)
• GitHub Check: Setup and Cache Dependencies
• GitHub Check: build-web
• GitHub Check: build-web
• GitHub Check: Analyze with CodeQL (javascript)

[bosomt]

QA OK

Info:

• Suite version: web 25.3.0 (ca937d5)
• Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/133.0.0.0 Safari/537.36
• OS: MacIntel
• Screen: 1470x956
• Device: Trezor T2T1 2.8.8 regular (revision 592590cf66a9b62dfeee7e4d2afb6e01005e5b2c)
• Transport: WebUsbTransport

[bosomt]

and attaching light mode version