-
-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(suite-native): suspicious device back button removed #16942
fix(suite-native): suspicious device back button removed #16942
Conversation
WalkthroughThe changes adjust the layout of a screen by modifying the component tree that renders buttons. Previously, a nested vertical container wrapped two buttons: one for contacting support and another for navigating back. The update removes the nested container and eliminates the back button entirely, leaving only the contact support button within the primary container. The handling logic for the support button remains unchanged, but users no longer have the option to navigate back from the screen. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
suite-native/module-onboarding/src/screens/SuspiciousDeviceScreen.tsx (1)
52-66
: Remove unused back navigation logic.Since the back button has been removed per design specs, the
handleBackButtonPress
function is now only used in theScreenHeader
'scloseAction
. Consider:
- Moving the navigation logic directly to the
closeAction
prop- Or removing the header's close action entirely if it's not needed per design
- const handleBackButtonPress = () => { - if (isNoPhysicalDeviceConnected) { - // Exit the onboarding flow if device was disconnected while was user on this screen. - navigation.navigate(RootStackRoutes.AppTabs, { - screen: AppTabsRoutes.HomeStack, - params: { - screen: HomeStackRoutes.Home, - }, - }); - - return; - } - - navigation.goBack(); - }; return ( - <Screen header={<ScreenHeader closeAction={handleBackButtonPress} />}> + <Screen>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
suite-native/module-onboarding/src/screens/SuspiciousDeviceScreen.tsx
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: EAS Update
- GitHub Check: Setup and Cache Dependencies
- GitHub Check: Analyze with CodeQL (javascript)
- GitHub Check: prepare_android_test_app
🔇 Additional comments (1)
suite-native/module-onboarding/src/screens/SuspiciousDeviceScreen.tsx (1)
106-112
: LGTM! Changes align with design specs.The removal of the back button and simplification of the button layout matches the PR objectives and design specifications. The contact support button is properly positioned and maintains its functionality.
🚀 Expo preview is ready!
|
Description
Related Issue
#16279
Screenshots: