Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(connect): update device authenticity config #16976

Conversation

MiroslavProchazka
Copy link
Contributor

@trezor/connect check data for device Authenticity

This is an automatically created PR.

@MiroslavProchazka MiroslavProchazka added the no-project This label is used to specify that PR doesn't need to be added to a project label Feb 13, 2025
Copy link

coderabbitai bot commented Feb 13, 2025

Walkthrough

The pull request adds new key entries to the device authenticity configuration. Specifically, six new caPubKeys entries are inserted under the T3B1 section, and eight new caPubKeys entries are added under the T3T1 section. The new keys are appended to the existing lists without modifying or removing any of the already present keys. Additionally, the debug sections for both T3B1 and T3T1 remain unchanged, preserving their respective configurations for rootPubKeys and caPubKeys.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5418393 and 1aacee4.

📒 Files selected for processing (1)
  • packages/connect/src/data/deviceAuthenticityConfig.ts (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (5)
  • GitHub Check: build-deploy
  • GitHub Check: build
  • GitHub Check: prepare_android_test_app
  • GitHub Check: Setup and Cache Dependencies
  • GitHub Check: Analyze with CodeQL (javascript)
🔇 Additional comments (4)
packages/connect/src/data/deviceAuthenticityConfig.ts (4)

1-7: LGTM! Well-documented file.

The file header clearly indicates its automated nature and provides a helpful link to internal documentation about device authenticity checks.


82-87: LGTM! New T3B1 CA public keys added correctly.

The six new CA public keys follow the correct format and are properly integrated into the T3B1 configuration.


126-134: LGTM! New T3T1 CA public keys added correctly.

The nine new CA public keys follow the correct format and are properly integrated into the T3T1 configuration.


82-87:

❓ Verification inconclusive

Verify authenticity of new CA public keys.

Please ensure that the newly added CA public keys match the authenticity data files in the Trezor data repository mentioned in the PR description.

Run this script to compare the keys:

Also applies to: 126-134


🏁 Script executed:

#!/bin/bash
# Description: Extract and display the new keys for manual verification against the source data

echo "New T3B1 CA public keys:"
rg -A 5 "04256936d48d9b60713b65f73a078cb8564f150e3986dfbf396d59b8b2a82cb8b6e33c145642d2993cbd6fa1d0e3efddc23d1b802fa786bb3e287f992d0079b66a"

echo -e "\nNew T3T1 CA public keys:"
rg -A 8 "043306644c3934ca5540cfd061a59bbf2f9c6842de588baf83f35e4e537a4b06dd284488e15055ecdaa5a68c05448542695b893009f9021a04110f86d6a6dbbc52"

Length of output: 3405


Verify CA Public Keys Authenticity

The new CA public keys for both T3B1 (lines 82–87) and T3T1 (lines 126–134) have been successfully added and are present in the file as confirmed by the verification script output. Please ensure that these keys exactly match the authenticity data from the Trezor data repository referenced in the PR description. Double-check the repository’s source data against these keys for complete validation.

  • File: packages/connect/src/data/deviceAuthenticityConfig.ts
    • T3B1 Keys: Lines 82–87
    • T3T1 Keys: Lines 126–134

If the keys do not match the expected source data, update them accordingly.

✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@komret komret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK except for submodules.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mergiiis

@MiroslavProchazka MiroslavProchazka force-pushed the chore/update-device-authenticity-config-1b6b7e24ea6955daf4b62821cf387df33b0fe8f816a3228107350a309924d525 branch from d634519 to 5418393 Compare February 13, 2025 12:55
@MiroslavProchazka MiroslavProchazka force-pushed the chore/update-device-authenticity-config-1b6b7e24ea6955daf4b62821cf387df33b0fe8f816a3228107350a309924d525 branch from 5418393 to 1aacee4 Compare February 13, 2025 12:58
@komret komret merged commit 6ba9ead into develop Feb 13, 2025
53 checks passed
@komret komret deleted the chore/update-device-authenticity-config-1b6b7e24ea6955daf4b62821cf387df33b0fe8f816a3228107350a309924d525 branch February 13, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-project This label is used to specify that PR doesn't need to be added to a project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants