Fix trezord-node fw update on Windows

[marekrjpolak]

Description

This should fix failing reconnection at the end of fw update on Windows when using Node bridge. Also other minor improvements.

[coderabbitai]

Walkthrough

The changes modify two modules in the transport package. The abstract API class has been updated to remove specific error event types from its event emission configuration, simplifying its error handling model. In the USB API, the connection handler is now asynchronous to support additional device management operations such as closing an already opened device during reconnection scenarios. Additionally, the disconnection handler has been adjusted to invoke device enumeration when a disconnected device lacks a serial number, while standardizing error logging by removing the emission of a specific error event. Minor refinements include adjustments to method signatures and parameter handling in the enumeration logic.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6ba9ead and 0d12869.

📒 Files selected for processing (2)

• packages/transport/src/api/abstract.ts (0 hunks)
• packages/transport/src/api/usb.ts (3 hunks)

💤 Files with no reviewable changes (1)

• packages/transport/src/api/abstract.ts

⏰ Context from checks skipped due to timeout of 90000ms (12)

• GitHub Check: build-deploy
• GitHub Check: run-desktop-tests (@group=wallet, trezor-user-env-unix bitcoin-regtest)
• GitHub Check: run-desktop-tests (@group=other, trezor-user-env-unix)
• GitHub Check: run-desktop-tests (@group=settings, trezor-user-env-unix bitcoin-regtest)
• GitHub Check: transport-e2e-test
• GitHub Check: build
• GitHub Check: run-desktop-tests (@group=device-management, trezor-user-env-unix)
• GitHub Check: build-web
• GitHub Check: Setup and Cache Dependencies
• GitHub Check: build-web
• GitHub Check: run-desktop-tests (@group=suite, trezor-user-env-unix)
• GitHub Check: Analyze with CodeQL (javascript)

🔇 Additional comments (3)

packages/transport/src/api/usb.ts (3)

50-57: Excellent fix for Windows firmware update issues!

The addition of device closure before reconnection is crucial. It prevents LIBUSB_ERROR_IO errors that occur when a device reboots during firmware updates on Windows, ensuring a clean reconnection process.

---

72-78: Enhanced handling of bootloader devices!

Instead of ignoring devices without serial numbers (typically bootloader devices), the code now properly updates the device list through enumeration. This ensures better state synchronization, particularly during firmware updates when devices may switch between normal and bootloader modes.

---

181-184: Clean parameter passing in enumerate!

The simplified parameter passing to abortableMethod maintains functionality while improving code readability.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.