Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocomplete: Add "position" property to control component placement relative to the element #2801

Open
2 tasks done
prashanth-offcl opened this issue Aug 22, 2024 · 2 comments · May be fixed by #2846
Open
2 tasks done

Autocomplete: Add "position" property to control component placement relative to the element #2801

prashanth-offcl opened this issue Aug 22, 2024 · 2 comments · May be fixed by #2846
Assignees
@ElishaSamPeterPrabhu
Labels
1 1 story point external-request Bugs and features reported by individuals from other teams in Trimble modus-autocomplete

Comments

@prashanth-offcl
Copy link
Collaborator

prashanth-offcl commented Aug 22, 2024 •
edited
Loading

Prerequisites

Proposal

Introduce an optional 'position' property that allows the component to be positioned relative to the current element. it should accept various positioning options such as top, bottom, left, right, and auto, similar to how tooltips are positioned.

Acceptance criteria:

  • By default, the autocomplete position should be bottom to ensure backward compatibility.
  • The component should reposition seamlessly during page or container scroll.
  • The documentation should include the possible options and their default values.

Motivation and context

By introducing a dedicated position property, we can simplify the process and make it more intuitive for developers to align components accurately. This change will improve the flexibility and usability of the component, ensuring that it integrates seamlessly with various layouts and use cases.

What is the issue regarding ?

@trimble-oss/modus-web-components

Priority

High

What product/project are you using Modus Components for ?

modus-internal

What is your team/division name ?

modus-internal

Are you willing to contribute ?

None

Are you using Modus Web Components in production ?

No response
@github-actions GitHub Actions
Copy link

Hello @prashanth-offcl! Thanks for opening an issue. The Modus core team will get back to you soon (usually within 24-hours) and provide guidance on how to proceed. Contributors are welcome to participate in the discussion and provide their input on how to best solve the issue, and even submit a PR if they want to.

Please wait until the issue is ready to be worked on before submitting a PR, or you can reach out to the core team if it is time bound. For trivial things, or bugs that don't change the expected behaviors and UI, you can go ahead and make a PR.

@github-actions github-actions bot added the external-request Bugs and features reported by individuals from other teams in Trimble label Aug 22, 2024
@prashanth-offcl
Copy link
Collaborator Author

Related to #2783

@prashanth-offcl prashanth-offcl moved this from In Review to To Do in Modus Web Components Aug 22, 2024
@prashanth-offcl prashanth-offcl added modus-autocomplete and removed external-request Bugs and features reported by individuals from other teams in Trimble labels Aug 22, 2024
@github-actions github-actions bot added the external-request Bugs and features reported by individuals from other teams in Trimble label Aug 22, 2024
@prashanth-offcl prashanth-offcl moved this from To Do to In Progress in Modus Web Components Aug 26, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Modus Web Components Aug 30, 2024
@github-project-automation github-project-automation bot moved this from Done to To Do in Modus Web Components Aug 30, 2024
@prashanth-offcl prashanth-offcl added the 3 3 story points label Aug 30, 2024
@ElishaSamPeterPrabhu ElishaSamPeterPrabhu linked a pull request Sep 11, 2024 that will close this issue
Autocomplete: Add position prop #2846
Draft
13 tasks
@ElishaSamPeterPrabhu ElishaSamPeterPrabhu linked a pull request Sep 11, 2024 that will close this issue
Draft
13 tasks
@prashanth-offcl prashanth-offcl changed the title Autocomplete: Add "position" property to control component placement relative to the wrapped item Autocomplete: Add "position" property to control component placement relative to the element Sep 11, 2024
@prashanth-offcl prashanth-offcl removed a link to a pull request Sep 11, 2024
Autocomplete: Add position prop #2846
Draft
13 tasks
@prashanth-offcl prashanth-offcl linked a pull request Sep 11, 2024 that will close this issue
Autocomplete: Add position prop #2846
Draft
13 tasks
@prashanth-offcl prashanth-offcl added 1 1 story point and removed 3 3 story points labels Sep 16, 2024
@prashanth-offcl prashanth-offcl moved this from PR Review to In Progress in Modus Web Components Sep 16, 2024
@prashanth-offcl prashanth-offcl moved this from In Progress to PR Review in Modus Web Components Sep 30, 2024
@ElishaSamPeterPrabhu ElishaSamPeterPrabhu moved this from In Progress to In Review in Modus Web Components Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElishaSamPeterPrabhu ElishaSamPeterPrabhu

Labels
1 1 story point external-request Bugs and features reported by individuals from other teams in Trimble modus-autocomplete
Projects
Modus Web Components
Status: In Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Autocomplete: Add position prop trimble-oss/modus-web-components
2 participants
@prashanth-offcl @ElishaSamPeterPrabhu