Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select's Value Incorrect #3067

Open
2 tasks done
kuhnboy opened this issue Dec 11, 2024 · 1 comment
Open
2 tasks done

Select's Value Incorrect #3067

kuhnboy opened this issue Dec 11, 2024 · 1 comment
Labels
bug Something is wrong and needs to be addressed external-request Bugs and features reported by individuals from other teams in Trimble

Comments

@kuhnboy
Copy link

kuhnboy commented Dec 11, 2024

Prerequisites

Describe the issue

We have a sample that is attempting to programmatically set the value of the select.

We understand that due to #2953, that the value has to be set differently (of which the documentation still has to be updated #2995).

The problem, is that when the value is set programatically, the value when chosen through the UI does not change (though we do get a value change event which is nice).

We expect the value property of modus-select to be updated whenever the value is changed, but it doesn't. Therefore if we programatically set the value to 'Pear', and the user chooses 'Banana', and then the button is clicked to set the value to 'Pear' the select's current value does NOT change.

<html>

<head>
    <script src="test.bundle.js" type="module"></script>
</head>

<body>
    <modus-select id="demo-select-1" label="Pick a fruit" options-display-prop="display"></modus-select><br />
    <div>Value Property: <span id="valueProp"></span></div><br />
    <div>valueChange Value: <span id="valueChangeVal"></span></div><br />
    <button id="btnSetSelect">Set to Pear</button>

    <script>
        let select = document.querySelector('#demo-select-1');
        select.options = [{ display: 'Apple' }, { display: 'Banana' }, { display: 'Peach' }, { display: 'Pear' }];
        select.addEventListener('valueChange', (event) => {
            document.querySelector('#valueProp').innerText = JSON.stringify(select.value);
            document.querySelector('#valueChangeVal').innerText = event.detail.display;
        });
        document.querySelector('#btnSetSelect').addEventListener('click', () => {
            select.value = 'Pear';
            document.querySelector('#valueProp').innerText = JSON.stringify(select.value);
        });
    </script>
</body>

</html>

Reduced test cases

No response

What operating system(s) are you seeing the problem on?

No response

What browser(s) are you seeing the problem on?

No response

What is the issue regarding ?

@trimble-oss/modus-web-components

What version of npm package are you using ?

1.0.0

Priority

High

What product/project are you using Modus Components for ?

Trimble Unity

What is your team/division name ?

O&PS

Are you willing to contribute ?

None

Are you using Modus Web Components in production ?

No response
@kuhnboy kuhnboy added the bug Something is wrong and needs to be addressed label Dec 11, 2024
@github-actions github-actions bot added the external-request Bugs and features reported by individuals from other teams in Trimble label Dec 11, 2024
@github-actions GitHub Actions
Copy link

Hello @kuhnboy! Thanks for opening an issue. The Modus core team will get back to you soon (usually within 24-hours) and provide guidance on how to proceed. Contributors are welcome to participate in the discussion and provide their input on how to best solve the issue, and even submit a PR if they want to.

Please wait until the issue is ready to be worked on before submitting a PR, or you can reach out to the core team if it is time bound. For trivial things, or bugs that don't change the expected behaviors and UI, you can go ahead and make a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something is wrong and needs to be addressed external-request Bugs and features reported by individuals from other teams in Trimble
Projects
Modus Web Components
Status: In Review
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kuhnboy