json log format #115
Closed
json log format #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmccorm4
reviewed
May 8, 2024
rmccorm4
reviewed
May 8, 2024
include/triton/common/triton_json.h
Outdated
| WriteBuffer, rapidjson::UTF8<>, rapidjson::UTF8<>, | ||
| rapidjson::CrtAllocator, writeFlags> | ||
| writer(writebuffer); | ||
| writer.String(input.c_str()); |
There was a problem hiding this comment.
I was going to ask if this can fail if the input has some malformed or half-formed JSON in it, but it seems like it won't: Tencent/rapidjson#1767 (comment)
There was a problem hiding this comment.
error handling was a little tricky w.r.t to we usually log an error - so I didn't want to create a recursion by accident. Writing and error causes an error .... so would probably have to fail silently ... or print directly to the stdout ...
GuanLuo
reviewed
May 13, 2024
| @@ -125,7 +129,10 @@ class Logger { | |||
| // Flush the log. | |||
| void Flush(); | |||
|
|
|||
| static const std::array<const char*, Level::kINFO + 1> LEVEL_NAMES; | |||
There was a problem hiding this comment.
Should have defined Level:kEND then use it instead of Level::kINFO + 1, easy to miss if someone adds new log level and doesn't change there.
|
continued in new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.