Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add model_metric message #126

Merged
merged 10 commits into from
Nov 6, 2024
Merged

feat: Add model_metric message #126

merged 10 commits into from
Nov 6, 2024

Conversation

yinggeh
Copy link
Contributor

@yinggeh yinggeh commented Oct 29, 2024 •
edited
Loading

What does the PR do?

Tests new model_metrics message in pbtxt. Add example to override histogram buckets per-family.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • feat

Related PRs:

triton-inference-server/core#405
triton-inference-server/server#7752

Where should the reviewer start?

Test plan:

L0_metrics

  • CI Pipeline ID:
    20106057

Caveats:

Background

Default histogram buckets does not satisfy all use cases.

@yinggeh yinggeh added the enhancement New feature or request label Oct 29, 2024
@yinggeh yinggeh requested review from rmccorm4 and GuanLuo October 29, 2024 00:48
@yinggeh yinggeh self-assigned this Oct 29, 2024
This was referenced Oct 29, 2024
Merged
Merged
GuanLuo
GuanLuo reviewed Oct 29, 2024
View reviewed changes
protobuf/model_config.proto Show resolved Hide resolved
protobuf/model_config.proto Show resolved Hide resolved
protobuf/model_config.proto Outdated Show resolved Hide resolved
@yinggeh yinggeh force-pushed the yinggeh-DLIS-7457-per-model-metric-config branch from ea7779a to 4e9a528 Compare October 30, 2024 19:46
@yinggeh yinggeh requested a review from GuanLuo October 30, 2024 19:48
@yinggeh yinggeh force-pushed the yinggeh-DLIS-7457-per-model-metric-config branch from 849291b to 376f252 Compare October 31, 2024 03:36
@yinggeh yinggeh requested a review from rmccorm4 November 4, 2024 20:33
GuanLuo
GuanLuo reviewed Nov 5, 2024
View reviewed changes
protobuf/model_config.proto Outdated Show resolved Hide resolved
@yinggeh yinggeh requested a review from GuanLuo November 5, 2024 01:22
rmccorm4
rmccorm4 reviewed Nov 5, 2024
View reviewed changes
Copy link
Contributor

@rmccorm4 rmccorm4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than https://github.com/triton-inference-server/common/pull/126/files#r1828699475

GuanLuo
GuanLuo previously approved these changes Nov 5, 2024
View reviewed changes
@yinggeh yinggeh requested a review from rmccorm4 November 6, 2024 00:12
@yinggeh yinggeh merged commit 3948525 into main Nov 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmccorm4 rmccorm4 rmccorm4 approved these changes

@GuanLuo GuanLuo GuanLuo left review comments

Assignees

@yinggeh yinggeh

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yinggeh @rmccorm4 @GuanLuo