Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core rebuild is extremely long #4819

Open
alxmamaev opened this issue Aug 29, 2022 · 5 comments
Open

Core rebuild is extremely long #4819

alxmamaev opened this issue Aug 29, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@alxmamaev
Copy link
Contributor

I'm trying to add my specific functionality into triton-core, but rebuilding and testing this is exceptionally long.
Most of the time spends on grpc-patching which is just a dumb copy of thousands of files, its take for me 7-8 minutes for every re-build.

What is your development pipeline? How can I build gRPC with a patch just once and then just skip this step?

P.S. I already checked the cmake_build script and did not find any helpful things there.

@alxmamaev
Copy link
Contributor Author

The hotfix is to use some hash-compare in the script before run rmtree and copytree.
But maybe you have some CMake trick to not execute ExternalProject_Add, IDK, I'm not cmake-expert

@alxmamaev
Copy link
Contributor Author

Time to rebuild on my MacBook M1:

Rebuild with grpc-patch

real    9m11.775s
user    0m12.029s
sys     1m17.344s

Rebuild with commented grpc-patch

real    1m36.359s
user    0m2.616s
sys     0m12.435s

🤯🤯🤯🤯🤯

@rmccorm4
Copy link
Contributor

CC @nv-kmcgill53

@nv-kmcgill53
Copy link
Contributor

Hi @alxmamaev, I was able to reproduce your issue. I think your solution of hashing the files/directories is the best way forward for this issue, and we may want to apply this more generally to the project. I have filed a ticket DLIS-4114, but I can't give a timeline for when this will be worked. I will cc @GuanLuo in case he has more insight.

@nv-kmcgill53 nv-kmcgill53 added the enhancement New feature or request label Aug 30, 2022
@alxmamaev
Copy link
Contributor Author

@nv-kmcgill53 Ok, im just using my hot-fix for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

3 participants