-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core rebuild is extremely long #4819
Comments
The hotfix is to use some hash-compare in the script before run rmtree and copytree. |
Time to rebuild on my MacBook M1: Rebuild with grpc-patch
Rebuild with commented grpc-patch
🤯🤯🤯🤯🤯 |
Hi @alxmamaev, I was able to reproduce your issue. I think your solution of hashing the files/directories is the best way forward for this issue, and we may want to apply this more generally to the project. I have filed a ticket DLIS-4114, but I can't give a timeline for when this will be worked. I will cc @GuanLuo in case he has more insight. |
@nv-kmcgill53 Ok, im just using my hot-fix for now. |
I'm trying to add my specific functionality into triton-core, but rebuilding and testing this is exceptionally long.
Most of the time spends on grpc-patching which is just a dumb copy of thousands of files, its take for me 7-8 minutes for every re-build.
What is your development pipeline? How can I build gRPC with a patch just once and then just skip this step?
P.S. I already checked the cmake_build script and did not find any helpful things there.
The text was updated successfully, but these errors were encountered: