Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid daemon creation #27

Open
boussou opened this issue Jul 26, 2021 · 1 comment
Open

Avoid daemon creation #27

boussou opened this issue Jul 26, 2021 · 1 comment

Comments

@boussou
Copy link

boussou commented Jul 26, 2021

I often noticed there are remaining processes that become deamons at the event the terminal window lost connexion. I think it was never the case in the earlier versions of redir (not sure about this)

case:

  • you get redir active on some port
  • you brutally close the connection ( laptop to sleep, close the term window)

would it be possible to listen to signal() & avoid that kind of situation?

@troglobit
Copy link
Owner

The double forking (detaching) of children was part of Sam's original implementation. The idea, from what I can tell, is to keep the code as simple as possible. I guess before that change, in 9da9b3c, they likely had problems with zombies instead. With fully detached children there no longer exist any bond between the processes.

It's quite a lot of work to fix and retest this, but patches are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants