Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build issues with VS2010 #10

Closed
kachanovskiy opened this issue Apr 11, 2018 · 4 comments
Closed

build issues with VS2010 #10

kachanovskiy opened this issue Apr 11, 2018 · 4 comments

Comments

@kachanovskiy
Copy link
Contributor

Hi,

out of the box, josepp does not build with VS2010 due to being written in proper C++11 :), which is a problem for VS2010 as it does not fully implement it.

I have finally managed to compile it with VS2010, so I can provide you a PR to fix this, if the following fixes look ok to you - I had to:

  1. remove "final" from class definitions
  2. remove type aliases (and replace them with typedefs)
  3. remove delegating constructors (copying initialization list from non-default constructor)
  4. remove variadic template use in make_shared methods in claims (seems ok, as these methods are never used)
  5. change enum classes to plain enums (shouldn't change semantics since enum classes do not contain methods)
  6. remove std::bind from lambda use in tests (looks ok as lambda's capture list is empty) - can also be done by replacing lambda with a normal function returning bool

I have also made some minor changes to CMake files:

  1. changed explicit use of pkg-config (not supported on Windows) to Unix-only
  2. compiler flags also made platform-specific
  3. for some reason, jwtpp-test is added as test instead of above configured josepp-test

Let me know if you need this.

Thanks.
Sergey.

@kachanovskiy
Copy link
Contributor Author

this, of course, can be also done by wrapping changed pieces into ifdef's...

@troian
Copy link
Owner

troian commented Apr 12, 2018

Seems to be reasonable. though VS2010 is quite old.
Lets split it into 2 parts. Firstly push your changes to CMake and then we think about code

@kachanovskiy
Copy link
Contributor Author

I'll put together PRs today.

VS2010 is quite old, yet it is widely adopted in, for example, automotive industry (where I work :)) due to several major libraries/frameworks being built with and supported only when used with VS2010.

kachanovskiy pushed a commit to kachanovskiy/josepp that referenced this issue Apr 18, 2018
kachanovskiy pushed a commit to kachanovskiy/josepp that referenced this issue Apr 18, 2018
kachanovskiy pushed a commit to kachanovskiy/josepp that referenced this issue Apr 18, 2018
kachanovskiy pushed a commit to kachanovskiy/josepp that referenced this issue Apr 18, 2018
…ted hpp/cpp files, tests, added two Windows libraries to build tests
troian added a commit that referenced this issue Apr 20, 2018
@troian
Copy link
Owner

troian commented Apr 20, 2018

Merged

@troian troian closed this as completed Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants