🐛 Skip empty url lines #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttsukagoshi
approved these changes
Nov 23, 2023
|
Hi @skerit, thank you for your contribution. Small changes, big improvement! 🎊 |
|
confirmed I'm running into this too. Did this make the latest stable? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My colleague kept getting the
Protocol error (Page.navigate): Cannot navigate to invalid URLerror, even though the URLs in theurls.txtfile seemed ok.Turns out it was because her text editor kept adding a trailing newline, breaking the script.
A lot of editors do this, and it's not really clear to the user what is exactly going wrong, so it's best to just filter out any empty line.