From bc0af58a72f32f401a15cb0ed2019597506d7c24 Mon Sep 17 00:00:00 2001 From: George Navarro Date: Sun, 8 Dec 2024 00:01:03 -0800 Subject: [PATCH 1/4] Fixed infinite recursion in the setter LaunchAction.pathRunnable --- Sources/XcodeProj/Scheme/XCScheme+LaunchAction.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Sources/XcodeProj/Scheme/XCScheme+LaunchAction.swift b/Sources/XcodeProj/Scheme/XCScheme+LaunchAction.swift index 53d52915..1724b080 100644 --- a/Sources/XcodeProj/Scheme/XCScheme+LaunchAction.swift +++ b/Sources/XcodeProj/Scheme/XCScheme+LaunchAction.swift @@ -48,7 +48,7 @@ public extension XCScheme { runnable as? PathRunnable } set { - self.pathRunnable = newValue + self.runnable = newValue } } From aac6fe111c90092ea21531660ad261f1405367a6 Mon Sep 17 00:00:00 2001 From: George Navarro Date: Sun, 8 Dec 2024 00:10:54 -0800 Subject: [PATCH 2/4] Moved the deprecation notice to the correct initializer --- Sources/XcodeProj/Scheme/XCScheme+LaunchAction.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Sources/XcodeProj/Scheme/XCScheme+LaunchAction.swift b/Sources/XcodeProj/Scheme/XCScheme+LaunchAction.swift index 1724b080..52774bb6 100644 --- a/Sources/XcodeProj/Scheme/XCScheme+LaunchAction.swift +++ b/Sources/XcodeProj/Scheme/XCScheme+LaunchAction.swift @@ -87,7 +87,6 @@ public extension XCScheme { // MARK: - Init - @available(*, deprecated, message: "Use the init() that consolidates pathRunnable and runnable into a single parameter.") public init(runnable: Runnable?, buildConfiguration: String, preActions: [ExecutionAction] = [], @@ -170,6 +169,7 @@ public extension XCScheme { super.init(preActions, postActions) } + @available(*, deprecated, message: "Use the init() that consolidates pathRunnable and runnable into a single parameter.") public convenience init( pathRunnable: PathRunnable?, buildConfiguration: String, From 05d3d7659c726881d56e3ee202207c4a9e700044 Mon Sep 17 00:00:00 2001 From: George Navarro Date: Tue, 10 Dec 2024 12:34:27 -0800 Subject: [PATCH 3/4] Fixed up inits as suggested in review --- Sources/XcodeProj/Scheme/XCScheme+LaunchAction.swift | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Sources/XcodeProj/Scheme/XCScheme+LaunchAction.swift b/Sources/XcodeProj/Scheme/XCScheme+LaunchAction.swift index 52774bb6..8c610974 100644 --- a/Sources/XcodeProj/Scheme/XCScheme+LaunchAction.swift +++ b/Sources/XcodeProj/Scheme/XCScheme+LaunchAction.swift @@ -96,7 +96,6 @@ public extension XCScheme { selectedLauncherIdentifier: String = XCScheme.defaultLauncher, launchStyle: Style = .auto, askForAppToLaunch: Bool? = nil, - pathRunnable _: PathRunnable? = nil, customWorkingDirectory: String? = nil, useCustomWorkingDirectory: Bool = false, ignoresPersistentStateOnLaunch: Bool = false, @@ -171,7 +170,7 @@ public extension XCScheme { @available(*, deprecated, message: "Use the init() that consolidates pathRunnable and runnable into a single parameter.") public convenience init( - pathRunnable: PathRunnable?, + runnable: Runnable?, buildConfiguration: String, preActions: [ExecutionAction] = [], postActions: [ExecutionAction] = [], @@ -180,6 +179,7 @@ public extension XCScheme { selectedLauncherIdentifier: String = XCScheme.defaultLauncher, launchStyle: Style = .auto, askForAppToLaunch: Bool? = nil, + pathRunnable: PathRunnable?, customWorkingDirectory: String? = nil, useCustomWorkingDirectory: Bool = false, ignoresPersistentStateOnLaunch: Bool = false, @@ -222,7 +222,6 @@ public extension XCScheme { selectedLauncherIdentifier: selectedLauncherIdentifier, launchStyle: launchStyle, askForAppToLaunch: askForAppToLaunch, - pathRunnable: pathRunnable, customWorkingDirectory: customWorkingDirectory, useCustomWorkingDirectory: useCustomWorkingDirectory, ignoresPersistentStateOnLaunch: ignoresPersistentStateOnLaunch, From 2c23caa5b92403673508fe537b2ab8c9b8a5331c Mon Sep 17 00:00:00 2001 From: Pedro Date: Thu, 19 Dec 2024 10:30:10 +0100 Subject: [PATCH 4/4] Fix linting issues --- Sources/XcodeProj/Scheme/XCScheme+LaunchAction.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Sources/XcodeProj/Scheme/XCScheme+LaunchAction.swift b/Sources/XcodeProj/Scheme/XCScheme+LaunchAction.swift index 8c610974..88989823 100644 --- a/Sources/XcodeProj/Scheme/XCScheme+LaunchAction.swift +++ b/Sources/XcodeProj/Scheme/XCScheme+LaunchAction.swift @@ -48,7 +48,7 @@ public extension XCScheme { runnable as? PathRunnable } set { - self.runnable = newValue + runnable = newValue } }