Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Term search: multiple (apparently) equal results may be returned. #98

Open
f-marino opened this issue Nov 21, 2022 · 0 comments
Open

Term search: multiple (apparently) equal results may be returned. #98

f-marino opened this issue Nov 21, 2022 · 0 comments

Comments

@f-marino
Copy link

f-marino commented Nov 21, 2022

Multiple terms can have exactly the same name (but be under different branches of the ontology tree) and then be shown as duplicated entries in the returned result. You need to expand the returned entries to distinguish between the two.

This could be fixed by showing a warning in the frontend advising the user to do so, when multiple "equal" terms are detected.

here an example with the bioref test dataset
image

image

This however does not address the problem that a user could select a term while thinking it is another term.
E.g., the user wants to select the term under "has lab result testkit", but only the term under "has lab result device" is shown if the user simply searches "gudid" and does not expand the element.

image

So probably the solution to both problems is to ALWAYS show a disclaimer in the term search bar, stating that users should always check that the returned term is indeed te one they were looking for, by looking at the path.


Another problem, which however probably deserves an issue on its own, is that if there are more than 10 terms that have EXACTLY the same name, terms from 11 to N will never be reachable through the term search function. I guess the only solution there is to give the user the possibility to ask for more terms.

But is it actually worth it? If a user must check one by one more than 10 results to find the right one, he would probably rather navigating the ontology tree.

f-marino added a commit that referenced this issue Mar 22, 2023
* Remove unused API function

* Remove unused dependencies

* Remove unused imports

* Put back needed packages

* Remove unused declarations

* Show full ontology path in search term. Fixing #98

* made ontology search limit configurable

---------

Co-authored-by: Francesco Marino <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants