Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing CI tests #49

Closed
Acconut opened this issue Jan 17, 2022 · 2 comments · Fixed by #91
Closed

Fix failing CI tests #49

Acconut opened this issue Jan 17, 2022 · 2 comments · Fixed by #91
Assignees
@Acconut

Comments

@Acconut
Copy link
Member

Acconut commented Jan 17, 2022

No description provided.

@Acconut Acconut self-assigned this Jan 17, 2022
@nhairs nhairs mentioned this issue Dec 11, 2023
Closed
@nhairs
Copy link
Contributor

nhairs commented Dec 11, 2023

I'm assuming this was related to the Windows tests failing. Looks like it was because git was automatically converting \n to \r\n newlines for text files. Because the test files were text files they were affected.

Adding in static test files and adding a .gitattributes file appears to have solved this

@Acconut
Copy link
Member Author

Acconut commented Dec 12, 2023

Thanks for looking into this! The Windows tests have been bothering us for some time, but you were able to fix them 🎉 I will have a thorough look at your PR soon.

@Acconut Acconut linked a pull request Dec 12, 2023 that will close this issue
Move to pyproject.toml and cleanup non-source files #89
Closed
@Acconut Acconut mentioned this issue Dec 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Acconut Acconut

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Acconut @nhairs