Trying to prevent candidates before offer

daonb · daonb · commit 46318f165044 · 2023-11-22T14:01:22.000+02:00
diff --git a/src/webrtc_session.ts b/src/webrtc_session.ts
@@ -441,7 +441,6 @@ export class PeerbookSession extends WebRTCSession {
             this.onStateChange("failed", Failure.InternalError)
             return
         }
-        this.pc.setLocalDescription(d)
         try {
             await terminal7.pb.adminCommand({type: "offer",
                                       args: {
@@ -451,7 +450,9 @@ export class PeerbookSession extends WebRTCSession {
         } catch(e) {
             terminal7.log("failed to send offer", e)
             this.onStateChange("failed", e)
+            return
         }
+        this.pc.setLocalDescription(d)
     }
     peerAnswer(offer) {
         const sd = new RTCSessionDescription(offer)

Original file line number	Diff line number	Diff line change
`@@ -441,7 +441,6 @@ export class PeerbookSession extends WebRTCSession {`
`441`	`441`	`this.onStateChange("failed", Failure.InternalError)`
`442`	`442`	`return`
`443`	`443`	`}`
`444`		`- this.pc.setLocalDescription(d)`
`445`	`444`	`try {`
`446`	`445`	`await terminal7.pb.adminCommand({type: "offer",`
`447`	`446`	`args: {`
`@@ -451,7 +450,9 @@ export class PeerbookSession extends WebRTCSession {`
`451`	`450`	`} catch(e) {`
`452`	`451`	`terminal7.log("failed to send offer", e)`
`453`	`452`	`this.onStateChange("failed", e)`
	`453`	`+ return`
`454`	`454`	`}`
	`455`	`+ this.pc.setLocalDescription(d)`
`455`	`456`	`}`
`456`	`457`	`peerAnswer(offer) {`
`457`	`458`	`const sd = new RTCSessionDescription(offer)`