Adding a todo comment, #106

daonb · daonb · commit 339e1ece8eaf · 2024-05-22T11:37:28.000+03:00
diff --git a/peers/pane.go b/peers/pane.go
@@ -97,7 +97,9 @@ func NewPane(peer *Peer, ws *pty.Winsize, parent int) (*Pane, error) {
 			return nil, fmt.Errorf(
 				"Got a pane request with an illegal parrent pane id: %d", parent)
 		}
-		parent = parentPane.C.Process.Pid
+		//TODO: handle a crash here, when there's a parent pane but no process yet
+		//      https://github.com/tuzig/webexec/issues/106
+		-parent = parentPane.C.Process.Pid
 	}
 	if ws != nil {
 		vt = vt10x.New(vt10x.WithSize(int(ws.Cols), int(ws.Rows)))

Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,9 @@ func NewPane(peer Peer, ws pty.Winsize, parent int) (*Pane, error) {`
`97`	`97`	`return nil, fmt.Errorf(`
`98`	`98`	`"Got a pane request with an illegal parrent pane id: %d", parent)`
`99`	`99`	`}`
`100`		`- parent = parentPane.C.Process.Pid`
	`100`	`+ //TODO: handle a crash here, when there's a parent pane but no process yet`
	`101`	`+ // https://github.com/tuzig/webexec/issues/106`
	`102`	`+ -parent = parentPane.C.Process.Pid`
`101`	`103`	`}`
`102`	`104`	`if ws != nil {`
`103`	`105`	`vt = vt10x.New(vt10x.WithSize(int(ws.Cols), int(ws.Rows)))`