Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow zero rollover in mpegts-demuxer #18

Open
slifty opened this issue May 31, 2021 · 0 comments · May be fixed by #19
Open

Allow zero rollover in mpegts-demuxer #18

slifty opened this issue May 31, 2021 · 0 comments · May be fixed by #19

Comments

@slifty
Copy link
Member

slifty commented May 31, 2021

Task

Description

After a few days of a stream the PTS timestamps will roll back to zero; we need to allow for this (the current logic does not allow PTS to go backwards).

One reason for the current explicit increase logic is to handle out-of-order packets, but I'm not sure if that is a real concern for the use case here, we can simply say to the end user that if you provide out of order packets, you may have out of order PTS times.
slifty added a commit that referenced this issue May 31, 2021
@slifty
Allow pts rollover
9f75da5 
The MPEG-TS pts field can roll over after a stream has been on for
a sufficiently long time (e.g. a week or so).

There was a failsafe built into the demuxer that would prevent PTS from
ever decreasing -- this was because normally PTS is not supposed to
decrease (outside of rollovers).

This change now assumes that the data stream will be passed in order in
order to maintain that PTS condition.

Issue #18
@slifty slifty linked a pull request May 31, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow pts rollover tvkitchen/utilities
1 participant
@slifty