This repository has been archived by the owner on Aug 18, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 0
Add migration files #1
Draft
hayato24s
wants to merge
7
commits into
main
Choose a base branch
from
feature/add-db-migrations
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
チェック量が多いので時間がかかっていますがチェック中なのでもう少々お待ちを~ |
|
@hayato24s ファイルの差分を確認しました。 |
|
seqの箇所は修正しました。 sequences
|
takonasu
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ごめんなさい、確認してApproveするのを失念していましたmm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
db/migrations
既存のマイクロサービスを立ち上げた後、pgAdminからDDLをコピペしてマイグレーションファイルを作成しました。
db/models
DBのテーブル構造からGoのコードを生成する
sqlboiler
というORMを使用しています。自動生成です。
schemaspy
schemaspyというツールで自動生成してます。
レビューして頂きたい点
マイグレーションファイルのクエリが既存のサービスのDB構造と矛盾していないか確認して頂きたいです。
pgAdminからコピペしてきたのですが、大丈夫でしたでしょうか?