Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-requirements.txt: uses mypy==0.790 #592

Closed
blueyed opened this issue Apr 13, 2021 · 5 comments · Fixed by #593
Closed

dev-requirements.txt: uses mypy==0.790 #592

blueyed opened this issue Apr 13, 2021 · 5 comments · Fixed by #593
Labels
bug Something isn't working

Comments

@blueyed
Copy link
Contributor

blueyed commented Apr 13, 2021 •
edited
Loading

While pip install -e . installs "mypy>=0.790" (

django-stubs/setup.py

Line 24 in cc746ab

"mypy>=0.790",
), pip install -r ./dev-requirements.txt installs "mypy==0.790" (

django-stubs/dev-requirements.txt

Line 2 in cc746ab

mypy==0.790
, via 44151c4 (#485)).

dev-requirements.txt is also used on CI, using the pinned/older mypy there for tests: https://github.com/typeddjango/django-stubs/pull/591/checks?check_run_id=2337419461#step:6:124

While I think that pinning (test) dependencies is good in general, I am not sure if this is really intended - and it should probably get upgraded/bumped, or even parametrized on CI maybe?
@blueyed blueyed added the bug Something isn't working label Apr 13, 2021
@sobolevn
Copy link
Member

Yes, I guess we can remove mypy from dev-requirements. Because it is specified in setup.py.

@blueyed
Copy link
Contributor Author

blueyed commented Apr 13, 2021

Ok, same for typing-extensions then.

blueyed added a commit to blueyed/django-stubs that referenced this issue Apr 13, 2021
@blueyed
build(deps-dev): remove/unpin mypy/typing-extensions
f4dd067 
Closes typeddjango#592.
@blueyed blueyed mentioned this issue Apr 13, 2021
Merged
@blueyed
Copy link
Contributor Author

blueyed commented Apr 13, 2021

Started in #593.

What's your take on testing against specific/different mypy versions on CI?

@sobolevn
Copy link
Member

What's your take on testing against specific/different mypy versions on CI?

I think that this can be done, but AFAIK, mypy versions are pretty easy to update. And that's what we recommend.
On the other hand, mypy can tweak its internals a bit: sometimes some variables change their "inference" status and start / stop using * in the output. They can also change the type-var numeration. This can be fatal to our tests (blocked by typeddjango/pytest-mypy-plugins#45).

So, it is probably a good thing, but I don't see a lot of value.

@sobolevn
Copy link
Member

@bluetech this is a great example of how different mypy versions can fail our CI: #593

sobolevn added a commit that referenced this issue Apr 14, 2021
@blueyed @sobolevn
build(deps-dev): remove/unpin mypy/typing-extensions (#593)
3c6f438 
* build(deps-dev): remove/unpin mypy/typing-extensions

Closes #592.

* Update test_options.yml

Co-authored-by: Nikita Sobolev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build(deps-dev): remove/unpin mypy/typing-extensions blueyed/django-stubs
2 participants
@blueyed @sobolevn