fix: update ecosia browser regex to match multiple versioning structures #595
Conversation
| family_replacement: 'Ecosia iOS' | ||
| - regex: '(Ecosia) android@(\d+)\.(\d+)\.(\d+)\.(\d+)' | ||
| - regex: '(Ecosia) android@(\d+)(?:\.(\d+)|)(?:\.(\d+)|)(?:\.(\d+)|)' |
There was a problem hiding this comment.
@csazevedo Loads of thanks for creating the PR! ✨ 🌳
For the sake of simplicity I would suggest to use (Ecosia) android@(\d+)
This would also match both versions, is easier to read and takes less processing steps. Same for iOS. What do you think?
There was a problem hiding this comment.
I would be ok with that but it doesn't follow the same pattern as the other ones that try to capture major, minor and patch versions. In this case if only the major version is provided it will be captured. If there's more detailed information it also captures it.
There was a problem hiding this comment.
I see - I did not consider that part. In that case your solution works just fine!
|
@lbarthon: Sincerest apologies for the shoutout and creating a sense of urgency. Though in my position of being the EM of the Native Apps team at Ecosia, I'd appreciate if you could give this PR a look and merge it in order to unblock the bugfix. THX! 🙏 |
|
@ecotopian no worries, @migueldemoura already had a look and this is merged! Thanks to all of you! |
Ecosia for Android changed it's versioning structure. I also changed Ecosia for iOS to accept the same structure for consistency and in case it will change in the future.