Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UserAgent Parser does not support patchMinor #70

Open
lukezhang2000 opened this issue Aug 22, 2022 · 0 comments
Open

UserAgent Parser does not support patchMinor #70

lukezhang2000 opened this issue Aug 22, 2022 · 0 comments

Comments

@lukezhang2000
Copy link

lukezhang2000 commented Aug 22, 2022

patchMinor is not included in the UserAgent Parser. For Chrome browsers, the parser will not catch the full name of the UserAgent, i.e. (https://github.com/ua-parser/uap-core/blob/09e9ccca9fcfc4348ae9e89815135bafcd0676bb/tests/test_ua.yaml#L2579-L2584)
For 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.78 Safari/537.36', the patchMinor would be "78", but that would not be captured by our parser.

Is the exclusion of patchMinor intentional for the UserAgent browser, or should that be added into the UserAgent class?

I believe there is an ongoing PR that's been out for this: #61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant