Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate yaml parsing to compile phase #77

Open
Sineaggi opened this issue Jan 31, 2023 · 2 comments · May be fixed by #83
Open

Migrate yaml parsing to compile phase #77

Sineaggi opened this issue Jan 31, 2023 · 2 comments · May be fixed by #83

Comments

@Sineaggi
Copy link

In order to remove yaml parsers from the uap-java library, we could pre-process the yaml file from uap-core and generate a Map at compile-time.
This would remove the dependency on snakeyaml, and increase the first-start time of the library.

jmini added a commit to unblu/uap-java that referenced this issue Apr 7, 2023
@jmini jmini linked a pull request Apr 7, 2023 that will close this issue
@jmini
Copy link

jmini commented Apr 7, 2023

This is really a good idea, I have created #83 for that.

@jmini
Copy link

jmini commented May 17, 2023

If you are interested by this idea, I have released this version on maven central:

<dependency>
  <groupId>com.unblu.ua-parser</groupId>
  <artifactId>uap-java</artifactId>
  <version>2.0.0</version>
</dependency>

From the fork https://github.com/unblu/uap-java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants