-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added multithreaded version of caching parser #24
Open
kyryloholodnov
wants to merge
2
commits into
ua-parser:master
Choose a base branch
from
kyryloholodnov:f-multithreaded-caching-parser
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,127 @@ | ||
package ua_parser; | ||
|
||
import com.google.common.cache.CacheBuilder; | ||
import com.google.common.cache.CacheLoader; | ||
import com.google.common.cache.LoadingCache; | ||
|
||
import javax.annotation.ParametersAreNonnullByDefault; | ||
import java.io.IOException; | ||
import java.io.InputStream; | ||
import java.util.concurrent.TimeUnit; | ||
|
||
/** | ||
* This class is concurrent version of CachingParser. | ||
* | ||
* @author kyryloholodnov | ||
*/ | ||
public class ConcurrentCachingParser extends Parser { | ||
|
||
private static long cacheKeyExpiresAfterAccessMs = 24 * 60L * 60 * 1000; // 24 hours | ||
private static long cacheMaximumSize = 1000; | ||
|
||
private final LoadingCache<String, Client> cacheClient = CacheBuilder.newBuilder() | ||
.expireAfterAccess(cacheKeyExpiresAfterAccessMs, TimeUnit.MILLISECONDS) | ||
.maximumSize(cacheMaximumSize) | ||
.build(new CacheLoader<String, Client>() { | ||
@Override | ||
@ParametersAreNonnullByDefault | ||
public Client load(String agentString) throws Exception { | ||
return ConcurrentCachingParser.super.parse(agentString); | ||
} | ||
}); | ||
|
||
private final LoadingCache<String, UserAgent> cacheUserAgent = CacheBuilder.newBuilder() | ||
.expireAfterAccess(cacheKeyExpiresAfterAccessMs, TimeUnit.MILLISECONDS) | ||
.maximumSize(cacheMaximumSize) | ||
.build(new CacheLoader<String, UserAgent>() { | ||
@Override | ||
@ParametersAreNonnullByDefault | ||
public UserAgent load(String agentString) throws Exception { | ||
return ConcurrentCachingParser.super.parseUserAgent(agentString); | ||
} | ||
}); | ||
|
||
private final LoadingCache<String, Device> cacheDevice = CacheBuilder.newBuilder() | ||
.expireAfterAccess(cacheKeyExpiresAfterAccessMs, TimeUnit.MILLISECONDS) | ||
.maximumSize(cacheMaximumSize) | ||
.build(new CacheLoader<String, Device>() { | ||
@Override | ||
@ParametersAreNonnullByDefault | ||
public Device load(String agentString) throws Exception { | ||
return ConcurrentCachingParser.super.parseDevice(agentString); | ||
} | ||
}); | ||
|
||
private final LoadingCache<String, OS> cacheOS = CacheBuilder.newBuilder() | ||
.expireAfterAccess(cacheKeyExpiresAfterAccessMs, TimeUnit.MILLISECONDS) | ||
.maximumSize(cacheMaximumSize) | ||
.build(new CacheLoader<String, OS>() { | ||
@Override | ||
@ParametersAreNonnullByDefault | ||
public OS load(String agentString) throws Exception { | ||
return ConcurrentCachingParser.super.parseOS(agentString); | ||
} | ||
}); | ||
|
||
public ConcurrentCachingParser() throws IOException { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove throws IOException |
||
super(); | ||
} | ||
|
||
public ConcurrentCachingParser(InputStream regexYaml) { | ||
super(regexYaml); | ||
} | ||
|
||
@Override | ||
public Client parse(String agentString) { | ||
if (agentString == null) { | ||
return null; | ||
} | ||
return cacheClient.getUnchecked(agentString); | ||
} | ||
|
||
@Override | ||
public UserAgent parseUserAgent(String agentString) { | ||
if (agentString == null) { | ||
return null; | ||
} | ||
return cacheUserAgent.getUnchecked(agentString); | ||
} | ||
|
||
@Override | ||
public Device parseDevice(String agentString) { | ||
if (agentString == null) { | ||
return null; | ||
} | ||
return cacheDevice.getUnchecked(agentString); | ||
} | ||
|
||
@Override | ||
public OS parseOS(String agentString) { | ||
if (agentString == null) { | ||
return null; | ||
} | ||
return cacheOS.getUnchecked(agentString); | ||
} | ||
|
||
public static long getCacheKeyExpiresAfterAccessMs() { | ||
return cacheKeyExpiresAfterAccessMs; | ||
} | ||
|
||
public static long getCacheMaximumSize() { | ||
return cacheMaximumSize; | ||
} | ||
|
||
public static void setCacheMaximumSize(long cacheMaximumSize) { | ||
if (cacheMaximumSize < 1) { | ||
throw new IllegalArgumentException("Cache size should be positive value"); | ||
} | ||
ConcurrentCachingParser.cacheMaximumSize = cacheMaximumSize; | ||
} | ||
|
||
public static void setCacheKeyExpiresAfterAccessMs(long cacheKeyExpiresAfterAccessMs) { | ||
if (cacheKeyExpiresAfterAccessMs < 1) { | ||
throw new IllegalArgumentException("Cache key expiration should be positive value"); | ||
} | ||
ConcurrentCachingParser.cacheKeyExpiresAfterAccessMs = cacheKeyExpiresAfterAccessMs; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,86 @@ | ||
package ua_parser; | ||
|
||
import org.junit.Before; | ||
import org.junit.Test; | ||
|
||
import java.io.ByteArrayInputStream; | ||
import java.io.InputStream; | ||
|
||
/** | ||
* These tests really only redo the same tests as in ParserTest but with a | ||
* different Parser subclass Also the same tests will be run several times on | ||
* the same user agents to validate the caching works correctly. | ||
* | ||
* @author kyryloholodnov | ||
*/ | ||
public class ConcurrentCachingParserTest extends ParserTest { | ||
|
||
@Before | ||
public void initParser() throws Exception { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove throws Exception |
||
parser = new ConcurrentCachingParser(); | ||
} | ||
|
||
@Override | ||
Parser parserFromStringConfig(String configYamlAsString) throws Exception { | ||
InputStream yamlInput = new ByteArrayInputStream( | ||
configYamlAsString.getBytes("UTF8")); | ||
return new CachingParser(yamlInput); | ||
} | ||
|
||
@Test | ||
public void testCachedParseUserAgent() { | ||
super.testParseUserAgent(); | ||
super.testParseUserAgent(); | ||
super.testParseUserAgent(); | ||
} | ||
|
||
@Test | ||
public void testCachedParseOS() { | ||
super.testParseOS(); | ||
super.testParseOS(); | ||
super.testParseOS(); | ||
} | ||
|
||
@Test | ||
public void testCachedParseAdditionalOS() { | ||
super.testParseAdditionalOS(); | ||
super.testParseAdditionalOS(); | ||
super.testParseAdditionalOS(); | ||
} | ||
|
||
@Test | ||
public void testCachedParseDevice() { | ||
super.testParseDevice(); | ||
super.testParseDevice(); | ||
super.testParseDevice(); | ||
} | ||
|
||
@Test | ||
public void testCachedParseFirefox() { | ||
super.testParseFirefox(); | ||
super.testParseFirefox(); | ||
super.testParseFirefox(); | ||
} | ||
|
||
@Test | ||
public void testCachedParsePGTS() { | ||
super.testParsePGTS(); | ||
super.testParsePGTS(); | ||
super.testParsePGTS(); | ||
} | ||
|
||
@Test | ||
public void testCachedParseAll() { | ||
super.testParseAll(); | ||
super.testParseAll(); | ||
super.testParseAll(); | ||
} | ||
|
||
@Test | ||
public void testCachedReplacementQuoting() throws Exception { | ||
super.testReplacementQuoting(); | ||
super.testReplacementQuoting(); | ||
super.testReplacementQuoting(); | ||
} | ||
|
||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's newer versions of this. Lets update to 31.1-jre