Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct usages should be minimal examples #9

Open
snadi opened this issue Jun 18, 2018 · 0 comments
Open

Correct usages should be minimal examples #9

snadi opened this issue Jun 18, 2018 · 0 comments
Labels
data-review discuss Things we need to discuss together

Comments

@snadi
Copy link
Contributor

snadi commented Jun 18, 2018

I noticed this is a recurrent issue so I guess we need to discuss it. I opened a more general issue here (The generalized description of Issue #5 ). This issue can be closed once we discuss how to create minimal examples and go through all identified problems to fix their correct usages. That said, this is not a showstopper for proceeding with the data review or Issue #7
@snadi snadi added data-review discuss Things we need to discuss together labels Jun 18, 2018
aradu12 added a commit that referenced this issue Jun 21, 2018
@aradu12
removed some unnecessary code (#9)
58fb2e9
aradu12 added a commit that referenced this issue Jun 21, 2018
@aradu12
minimized (#9)
14b0c64
aradu12 added a commit that referenced this issue Jun 21, 2018
@aradu12
minimized (#9)
3ba1337
aradu12 added a commit that referenced this issue Jun 21, 2018
@aradu12
minimized -- #9
076a25b
aradu12 added a commit that referenced this issue Jun 21, 2018
@aradu12
minimize -- #9
039f9ff
aradu12 added a commit that referenced this issue Jun 21, 2018
@aradu12
#9
2d51d7a
aradu12 added a commit that referenced this issue Jun 21, 2018
@aradu12
#9 -- updated more minimal
bcea41c
aradu12 added a commit that referenced this issue Jun 21, 2018
@aradu12
minimize -- issue #9
3910b70
aradu12 added a commit that referenced this issue Jun 21, 2018
@aradu12
rename and minimize -- #9
6e3b371
aradu12 added a commit that referenced this issue Jun 21, 2018
@aradu12
minimized, but are the last 3 lines needed? #9
9cda285
aradu12 added a commit that referenced this issue Jun 21, 2018
@aradu12
minimize (#9) + rename
bcb002e
aradu12 added a commit that referenced this issue Jun 21, 2018
@aradu12
minimize (#9)
eb15a1f
aradu12 added a commit that referenced this issue Jun 21, 2018
@aradu12
minimized (#9)
cbc855c
aradu12 added a commit that referenced this issue Jun 21, 2018
@aradu12
minimize (#9) + rename
59821c7
aradu12 added a commit that referenced this issue Jun 22, 2018
@aradu12
minimize (#9)
a19624e
aradu12 added a commit that referenced this issue Jun 22, 2018
@aradu12
put in right example and minimized (#9)
3261dc3
aradu12 added a commit that referenced this issue Jun 22, 2018
@aradu12
minimize (#9) and rename
79bc6ea
aradu12 added a commit that referenced this issue Jun 22, 2018
@aradu12
minimized (#9) but not sure if good (#13)
5c9fff4
aradu12 added a commit that referenced this issue Jun 22, 2018
@aradu12
minimize (#9)
1f81117
aradu12 added a commit that referenced this issue Jun 22, 2018
@aradu12
#9 but also #13
39c173b
aradu12 referenced this issue Jun 22, 2018
@aradu12
minimize
85d9763
aradu12 added a commit that referenced this issue Jun 22, 2018
@aradu12
minimize (#9)
f51e754
aradu12 added a commit that referenced this issue Jun 22, 2018
@aradu12
minimize (#9)
bad9915
aradu12 added a commit that referenced this issue Jun 22, 2018
@aradu12
rename and minimize (#9)
ffa7e61
aradu12 added a commit that referenced this issue Jun 22, 2018
@aradu12
rename + minimize (#9)
b0c0f7e
aradu12 added a commit that referenced this issue Jun 22, 2018
@aradu12
clean up a little (#9)
73f279b
aradu12 added a commit that referenced this issue Jun 22, 2018
@aradu12
minimized -- #9
344e7a7
aradu12 added a commit that referenced this issue Jun 22, 2018
@aradu12
minimize -- #9
a878297
aradu12 added a commit that referenced this issue Jun 22, 2018
@aradu12
minimize (#9)
627d17c
aradu12 added a commit that referenced this issue Jun 22, 2018
@aradu12
minimize (#9)
6343939
aradu12 added a commit that referenced this issue Jun 22, 2018
@aradu12
minimize (#9)
697e789
aradu12 added a commit that referenced this issue Jun 22, 2018
@aradu12
minimize (#9)
7c45f51 
the print wasn't necessary for the example to make sense
aradu12 added a commit that referenced this issue Jun 22, 2018
@aradu12
minimize (#9)
6c9a858
aradu12 added a commit that referenced this issue Jun 22, 2018
@aradu12
comment wasn't necessary -- #9
6b3f474
aradu12 added a commit that referenced this issue Jun 25, 2018
@aradu12
#9 and #13 --
3116b87 
necessary to have the full definition of download_chunk?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
data-review discuss Things we need to discuss together
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@snadi