Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting of navigation sidebar #3

Open
stephan-koenig opened this issue Feb 9, 2023 · 11 comments
Open

Formatting of navigation sidebar #3

stephan-koenig opened this issue Feb 9, 2023 · 11 comments
Assignees
Labels
bug Something isn't working

Comments

@stephan-koenig
Copy link

Hi,

The headers in the navigation sidebar are expanded instead of hidden, so all subheaders are visible on page load, and the subheaders are formatted differently compared to UBC CLF.

navigation_sidebar

@joelpittet joelpittet self-assigned this Feb 10, 2023
@joelpittet joelpittet added the bug Something isn't working label Feb 10, 2023
@joelpittet
Copy link
Member

Thanks @stephan-koenig I'll look into fixing this styling shortly, glad to see you are trying it out!

@stephan-koenig
Copy link
Author

Thanks, @joelpittet!

@joelpittet
Copy link
Member

@stephan-koenig I was thinking of taking the styles from this UBC site, it's not the CLF one as I think it's a bit nicer. Thoughts before I do that?
https://finance.ubc.ca/payroll/your-pay

Or the one we use for CS:
https://www.cs.ubc.ca/students/undergrad/careers

Preferences?

@stephan-koenig
Copy link
Author

I think I like the first one better: https://finance.ubc.ca/payroll/your-pay

@rloftus, what do you think?

@rloftus
Copy link

rloftus commented Feb 10, 2023

I agree, the first one is better @stephan-koenig

@joelpittet
Copy link
Member

Ok it's not 100% there yet but there is some progress.

  • Need to potentially collapse trees that are not active: @stephan-koenig Is what you're aiming for? This can be tricky because of the static nature of the way the menus are produced but probably not impossible.
  • Maybe more important the sub menu should probably not show the top level menu items but rather only the child pages?

@joelpittet
Copy link
Member

0.3.0 of the theme has the new style, use bundle update to see

@stephan-koenig
Copy link
Author

Ok it's not 100% there yet but there is some progress.

Looks already very neat! Thanks!

  • Need to potentially collapse trees that are not active: @stephan-koenig Is what you're aiming for? This can be tricky because of the static nature of the way the menus are produced but probably not impossible.

I imagined that the navigation is interactive, i.e., clicking on the top level would reveal the child pages for any menu item. But yes, ideally, all submenus except the current one should be collapsed.

  • Maybe more important the sub menu should probably not show the top level menu items but rather only the child pages?

I think it is better if the top level is shown so people know, e.g. if they are looking at the "Student Info" or "Faculty Info."

What do you think, @rloftus or @cheeren?

@joelpittet
Copy link
Member

@stephan-koenig generally in the CLF the side menu shows the secondary menu items (if they exist) and the primary menu items are shown across the top. Are you proposing an alternative to that?

Regarding the interactivity, I was thinking the sub menu in the side menu would expand if you're on that "branch" (parent or child menu items), and siblings that have sub menu items would be collapsed by default but clicking the arrow would expand them, clicking the text would go to that page. That pattern is on the CS external website https://www.cs.ubc.ca/students/undergrad/careers

@stephan-koenig
Copy link
Author

I must have misunderstood. The behaviour as you describe it sounds excellent!

@joelpittet
Copy link
Member

Ok great, I'll try to sneak some time in on Friday to push this a bit further

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants