Support actor object via annotation metadata
#221
Closed
+498
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
uhooi
requested changes
Mar 10, 2023
| } | ||
| """ | ||
|
|
||
| let argumentsObjectTypesWithActorAnnotation = |
There was a problem hiding this comment.
I would also like you to write the following test.
/// \(String.mockAnnotation)(object: actor)
protocol Foo: Bar {
func foo(arg: String) async -> Result<String, Error>
var bar: Int { get }
}
protocol Bar: Actor {
func baz(arg: String) async -> Result<String, Error>
var qux: Int { get }
}
treastrain
commented
Mar 13, 2023
sidepelican
requested changes
Mar 13, 2023
| import Foundation | ||
|
|
||
| extension ActorModel { | ||
| func applyActorTemplate(name: String, |
There was a problem hiding this comment.
Would you like to reduce a lot of duplication codes with ClassModel?
I have not good idea yet, but this size of duplications will cause future bug.
| struct AnnotationMetadata { | ||
| var objectType: ObjectType? |
There was a problem hiding this comment.
Please describe the usecase of this option.
Is it not enough when the protocol inherit Actor ?
(It seems that this option is added only to split the implementation 1 and 2 in #216 (comment))
There was a problem hiding this comment.
Oops, this is my misunderstanding. I understand 1 and 2 are not dependent of each other.
|
Same: #222 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Part of #216
(#216 (comment) 's "1.")
Description
Add an annotation "object: class/actor" for specifying the object nominal types of the mock.
This allows the user to choose, at his/her own risk, whether to generate the mock for the protocol as a class or as an actor.
For details: #216 (comment)