-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support actor
object conforming to Actor
protocol
#222
Support actor
object conforming to Actor
protocol
#222
Conversation
…tly conforms to the `Actor` protocol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx PR!!
|
||
let actorProtocol = | ||
""" | ||
/// \(String.mockAnnotation) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also like you to write the following test.
/// \(String.mockAnnotation)
protocol Foo: Bar {
func foo(arg: String) async -> Result<String, Error>
var bar: Int { get }
}
protocol Bar: Actor {
func baz(arg: String) async -> Result<String, Error>
var qux: Int { get }
}
@treastrain
ref: https://github.com/uber/mockolo/actions/runs/4376819642/jobs/7676406579#step:5:251 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can say the same things with #221 . See it.
Hi, I'm really interested in this feature and looking forward to its potential inclusion. |
I'm sorry. I have been away for a long time since I made this pull request. I will defer the rest of this to #266. |
Issue
Part of #216
(#216 (comment) 's "2.")
Description
Add feature generating mocks for that protocol that conform to the
Actor
automatically become actor.For details: #216 (comment)