Make fixture verification a bit strict #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Sources/MockoloFramework/Templates/ClosureTemplate.swift # Sources/MockoloFramework/Templates/NominalTemplate.swift # Tests/MockoloTestCase.swift # Tests/TestSendable/FixtureSendable.swift
sidepelican
commented
Dec 3, 2024
| public private(set) var myStringInBaseSetCallCount = 0 | ||
| @Published public var myStringInBase: String = "" { didSet { myStringInBaseSetCallCount += 1 } } | ||
| @Published public var myStringInBase: String = "" { didSet { myStringInBaseSetCallCount += 1 } } |
There was a problem hiding this comment.
I could find new bug 🤣
fummicc1
approved these changes
Dec 7, 2024
| class MyProtocolMock: MyProtocol { | ||
| private var _anotherParam: Any! | ||
| private var _anotherParam: Any! |
There was a problem hiding this comment.
Improvement of readability🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, in tests, the comparison between the fixture and the actually generated code is done on a word-by-word basis, separated by whitespace.
There might be unnecessary whitespace present in the actually generated code, which is not being detected.
I will make the process slightly more strict and change it to compare on a line-by-line basis.